Max Isom

Results 395 comments of Max Isom

Yep, a single PR would be ideal. I'm looking for something that's as little work as possible on my end since I no longer use or maintain this repo, so...

> As I currently don't have time for collab here, @codetheweb doesn't seem interested in looking into this and there are no other contributors this will probably persist for the...

Still happening in 1.6.7. Would love to use Preact and this is the only thing blocking the transition at the moment. :) Edit: I've spent several hours trying to trace...

I was able to reproduce this by creating a v210 encoded .mov file: https://user-images.githubusercontent.com/7410405/134365364-ab83c10e-b7ca-4510-8d92-a78209dba128.mov I'll try and take a look later today.

It seems that every `sampleBuffer.totalSampleSize == 0` (https://github.com/sindresorhus/Gifski/blob/5c966175e4b449c23b95cc962acc111294441e27/Gifski/Utilities.swift#L636) when scanning through the file. [This](https://stackoverflow.com/questions/9469931/avfoundation-read-raw-single-frames-from-mov-file-v210-uncompressed-10-bit-4) suggests that a different output format might be necessary, but I tried the ones listed and...

Strangely both the App Store version and my locally built version of Gifski crash when selecting any video file (including regular old h264 .mp4s) with the error: ``` Gifski[8973:1704424] [plugin]...

Was able to fix it. The error seems to be here: https://github.com/sindresorhus/Gifski/blob/5990ce3e7a2b3baae8beefbc52701a3336b37e85/Gifski/EstimatedFileSize.swift#L113 Specifying **either** `.controlSize()` or `.scaleEffect()` works fine, but specifying **both** results in a crash. I'm gonna hazard a...

v2.19.3 does seem to have fixed it for me. 👍

Getting back to the issue at hand: Not sure what's going on. I created a file that's as close to one of the logs above: > AVAsset debug info ##...

Given that we're not doing anything particularly fancy and this is happening across multiple codecs it seems to be a bug in AVFoundation in some capacity, but since I can't...