Conor Hoekstra

Results 41 comments of Conor Hoekstra

I am happy to use either Kris's `ut` or `Catch2`. If you open a PR, will be happy to merge.

I think in general our policy should be to add algorithms when we need them. So if this comes up in the future we can add it.

I have been looking into both C++ and Python exceptions. Here is a brief summary of the investigation. C++ Exceptions: https://en.cppreference.com/w/cpp/error/exception Python Exceptions: https://docs.python.org/3/library/exceptions.html#bltin-exceptions There are 26 C++ exceptions and...

I like the idea of `reduce_*`, something like `reduce_assoc` or `reduce_associative_only`/`reduce_noncommutative`. The former isn't great because `assoc` has meaning in [other contexts](https://clojuredocs.org/clojure.core/assoc) and the latter is a bit verbose. I...

@elbeno I know you don't work at NVIDIA but I know you have wanted this algorithm for a while and might have some thoughts on the name :slightly_smiling_face:

I just discovered that [Futhark](https://futhark-lang.org/) actually has [both of the reductions](https://futhark-lang.org/docs/prelude/doc/prelude/soacs.html#953). They are called: * `reduce` (our proposed `reduce_noncommutative`) * `reduce_comm` (our `reduce`)

Honestly, ruff `UP034` doesn't catch anything for me. pylint catches all of these: ```py assert (a == b) if (a == b): while (a == b): ``` and returns ```...

@charliermarsh Looking forward to when it is implemented. Currently the only thing I use pylint for is that check. Once it is added I can remove that dependency : )...

Not sure if the `--silent` would suppress warnings as well but that would be very helpful.

Awesome! Thanks - I will look into these!