smalltalk icon indicating copy to clipboard operation
smalltalk copied to clipboard

Support for different prompt types

Open ray73864 opened this issue 5 years ago • 3 comments

Have added support for date, email, number, and tel prompts in addition to the original password prompt.

Had to make it so that setSelectionRange would only happen if it was a password, text, or url input field otherwise it errors out.

Probably better ways to do some of it, but it works for my use case on a Honeywell CT60 Android barcode scanner.

ray73864 avatar Feb 28 '20 06:02 ray73864

Coverage Status

Coverage decreased (-1.1%) to 88.384% when pulling d01b5457f275484bb02c5115a1c827a039713692 on ray73864:master into 65f558632bf01811da7ca96c96295d1e1f1e9c8c on coderaiser:master.

coveralls avatar Feb 28 '20 06:02 coveralls

Could you please run npm run fix:lint to fix lint errors and provide test for this code :). Is this code works on desktop browsers?

coderaiser avatar Mar 07 '20 13:03 coderaiser

Should work fine on desktop browsers too, the only difference with desktop browsers is they won't see a customised on-screen keyboard but it will still limit what can be put into the prompt input field.

As for tests, I have no clue how to do them, and looking at the test/smalltalk.js file, it's kinda way over my head :(

ray73864 avatar Mar 07 '20 21:03 ray73864