smalltalk

smalltalk copied to clipboard

I wanted to be able to create a dialog in a separate window which meant I had to pass in a different document.body element to be the parent element.

It's probably a good idea to write a test for this scenario but I wasn't sure how to. If you point me in the right direction I'm happy to have a go at it though.

Coverage remained the same at 92.391% when pulling 7478ceb912a27125c2ad9f42d658b52f3bb119fa on aullman:master into a009d84e2e9bf9d903711ecb37cfec829d975775 on coderaiser:master.

Coverage decreased (-1.009%) to 91.383% when pulling 88aabec0b92765170fffec102580b697d9ff95b5 on aullman:master into a009d84e2e9bf9d903711ecb37cfec829d975775 on coderaiser:master.

Please reinstall dependencies, and run fix again. Things like:

const TAB = 9;	
const event = {
    keyCode: TAB,
}

Should stay :).

Sorry, just saw this. I reverted the unnecessary changes. Hopefully the tests pass this time.

Would be great if you add test for this :) and squash it to one commit.