sail icon indicating copy to clipboard operation
sail copied to clipboard

Why does cmd + r rebuild the container?

Open teddy-codes opened this issue 6 years ago • 4 comments

I was trying to reload the browser to get an extension to work (go tools). It rebuilt the container, so I now have to install them again. Just curious what the thought process was when implementing that.

teddy-codes avatar May 25 '19 14:05 teddy-codes

cc @nhooyr

ammario avatar May 25 '19 21:05 ammario

Ah that is unfortunate. I thought cmd+r was the most appropriate shortcut because it is usually used to mean "rebuild" but I didn't realize it conflicts with the browser. Will fix this by adding alt to the keybind.

nhooyr avatar May 25 '19 21:05 nhooyr

Yea, guess alt would be the best. Thanks 😊

teddy-codes avatar May 25 '19 23:05 teddy-codes

Wanted to make a PR for this, but it seems that if you change the key binding to Ctrl+Alt+R (via sail.js) it doesn't work in Firefox (works in Chromium, however). Upon further inspection, it looks like Alt just doesn't work in code-server in Firefox, so maybe we should pick a different keybind.

Made a bug report on code-server for Alt not working: https://github.com/cdr/code-server/issues/749

deansheather avatar Jun 05 '19 13:06 deansheather