sail icon indicating copy to clipboard operation
sail copied to clipboard

chrome extension error

Open Magistern opened this issue 6 years ago • 8 comments

O boy, this is why you want sail to just work. Not having to spend half a day getting things to work like it says in the documentation... So now that I finally got sail to get installed and start in terminal, I was hoping for the Chrome plugin to work, but no, of course not. I did sail install-for-chrome-ext

Uncaught DOMException: Failed to execute 'atob' on 'Window': The string to be decoded is not correctly encoded.
    at WebSocket.<anonymous> (chrome-extension://deeepphleikpinikcbjplcgojfhkcmna/out/content.js:146:29)

Magistern avatar May 22 '19 10:05 Magistern

That error is actually masking another one. @kylecarbs is pushing a fix so the terminal tooltip stays open and you can see what the full error is.

ammario avatar May 22 '19 15:05 ammario

@Magistern if you use Mac, please open terminal and open Chrome with following command:

open -a "Google Chrome"

I debuged the JS code, and find the problem, almost like docker path problem.

error to invoke docker info, and docker command is not in $PATH

almost like above. I think @ammario can fix $PATH problem on Mac.

linux-china avatar May 22 '19 16:05 linux-china

@kylecarbs is there any reason why the $PATH would be different than the one on the host?

ammario avatar May 22 '19 16:05 ammario

My env: Mac, Chrome 74.0, Docker Desktop for Mac, and docker command is under /usr/local/bin. If you open Chrome from Deck, and you will get $PATH problem with docker command not found.

linux-china avatar May 22 '19 16:05 linux-china

@Magistern if you use Mac, please open terminal and open Chrome with following command:

open -a "Google Chrome"

I did and that worked fine. Now when I click the blue button "open in sail" it starts showing code in the terminal tool tip but stops and dissapears after a while. I found the error log. It said:


2019-05-22 20:46:59 INFO	listening on http://127.0.0.1:52102
2019-05-22 20:47:09 FATAL	failed to refresh code-server port: failed while trying to find code-server port: Get http://localhost:32771: EOF

Magistern avatar May 22 '19 19:05 Magistern

So the problem is the chrome extension is ignoring errors: https://github.com/cdr/sail/blob/ac1dfa97eaf75dedacac677cd0d81eee1a63b940/extension/src/content.ts#L121

nhooyr avatar May 22 '19 19:05 nhooyr

@kylecarbs

nhooyr avatar May 22 '19 19:05 nhooyr

The error from websocket server side like following:

2019-05-22 15:57:21 FATAL	failed to run `docker info`: exec: "docker": executable file not found in $PATH

linux-china avatar May 22 '19 22:05 linux-china