moment-precise-range icon indicating copy to clipboard operation
moment-precise-range copied to clipboard

Published 20 hours ago • verified publisher icon codebox

i18n use monent relative time concept

Open Pliman opened this issue 11 years ago • 5 comments

Hello, it nice to find moment-precise-range, but it doesn't support i18n, so I added i18n support with monent relative time concept.

One thing not good is that, now 'a' will replace '1', eg. '1 month' -> 'a month' but moment did like this, make be it will change in the future, probably moment-precise-range with i18n support can still work.

Pliman avatar Apr 24 '14 08:04 Pliman

hm... I should change test as well, later.

Pliman avatar Apr 24 '14 08:04 Pliman

retrieved tests, ‘1 second’ and'xx seconds' now will be 'a few seconds' which comes from moment i18n file, I think this is not perfect.

Pliman avatar Apr 24 '14 15:04 Pliman

Hey, have you checked if "german (de)" is working for the i18n?

jbrockmeyer avatar Jun 13 '14 18:06 jbrockmeyer

Hi @Pliman and @codebox , happy new year :-)

I would have been interested by this PR, some years have passed, what's the status ? :-)

cmalard avatar Jan 08 '18 10:01 cmalard

Hi, @cmalard , the modified files conflicts with current version.

Conflicting files readable-range-test.js readable-range.js

Should fix the conficts based on current version, sometime.

Pliman avatar Jan 08 '18 15:01 Pliman