planner icon indicating copy to clipboard operation
planner copied to clipboard

Past events on events page only shows workshops and should show all past events

Open KimberleyCook opened this issue 4 years ago β€’ 7 comments

Description of the issue πŸ“„

The "Past Events" section on events page only shows workshops and should show all past events - including "Events", "Meetings" and "Workshops"

Screenshots πŸ“·

Steps to fix πŸ› 

To do πŸ“‹

  • [ ] Claim this issue (comment below, or assign yourself if you are part of the codebar org)
  • [ ] Fork and clone the repository
  • [ ] Update the relevant files. Follow the steps to fix section in this issue.
  • [ ] Commit your changes as one commit. Use the title of this issue as your commit message
  • [ ] Submit a pull request
  • [ ] Mention this issue in the PR description by including it's number
  • [ ] Have your pull request reviewed & merged by a codebar team member

KimberleyCook avatar Oct 04 '21 19:10 KimberleyCook

To be honest, I don’t understand how this can be… I wrote a test for it, I looked into the code, and everything seems to work as expected.

gnclmorais avatar Nov 12 '21 12:11 gnclmorais

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

github-actions[bot] avatar Feb 11 '22 00:02 github-actions[bot]

Closing as stale.

github-actions[bot] avatar Mar 13 '22 00:03 github-actions[bot]

I think this is still worth investigating so reopening the issue. @gnclmorais is right, this does work locally for me (I can see both the Event and Meeting event types in the past events list). I'm going to so some digging in the production data to see if I can pinpoint an issue. Could it be that we simply do not have a Meeting or Event in the list of the past 40 events (the code takes the last 40 past Workshops, Meetings and Events, chucks them all in an array, sorts the array by the date_and_time column, reverses the array and returns the first 40 of this collated array)?

@KimberleyCook could you re-create this issue with a very recently run Event?

matyikriszta avatar Apr 12 '22 02:04 matyikriszta

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

github-actions[bot] avatar Jul 12 '22 00:07 github-actions[bot]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

github-actions[bot] avatar Oct 11 '22 00:10 github-actions[bot]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

github-actions[bot] avatar Feb 01 '23 00:02 github-actions[bot]