errors

errors copied to clipboard

Stop relying on `pkg/errors` to handle stack traces

7

Today the stack trace formatting code delegates to `pkg/errors/stack.go`. However, that code uses `runtime.FuncForPC` and emits file paths in the stack trace derived from the raw file name of the...

knz

Implement slog.LogValuer

1

The new [slog](https://pkg.go.dev/golang.org/x/exp/slog) library provides a `slog.LogValuer` interface for formatting attributes. Documentation here: https://pkg.go.dev/golang.org/x/exp/slog#hdr-Customizing_a_type_s_logging_behavior I think cockroachdb/errors should implement it. ```go type customError struct { ... } func (e customError)...

samber

Implement slog.LogValuer

1

https://github.com/cockroachdb/errors/issues/107 This change is [](https://reviewable.io/reviews/cockroachdb/errors/129) code ``` go package main import ( "context" "log/slog" "os" "github.com/cockroachdb/errors" ) func f1() error { return errors.Wrap(f2(), "wrapped error 1") } func f2() error...

nozo-moto

Package has dependency of GoGO protobufs and too mainy inits

10

When inspecting go binary I found that it requires gogo protobufs https://github.com/cockroachdb/errors/blob/72ec75208141a2b67e79909b28aea29ed2189108/extgrpc/ext_grpc.go#L182 in init() I do not use gogo in production as it is an outdated project https://github.com/gogo/protobuf/issues/691 Please remove...

linux019

secondary: add SummarizeErrors variadic method

4

I was recently debugging a workflow with lots of async workers able to cancel each other, so that by the time an error bubbled up it was ambiguous where the...

HonoreDB

Possible "index out of range" in `equalMarks`

2

Hello! I'm interested in carefree [iteration](https://github.com/cockroachdb/errors/blob/217058372e2042c4d08384adbd883316372f1070/markers/markers.go#L200) over lists whose lengths can vary: ```go // equalMarks compares two error markers. func equalMarks(m1, m2 errorMark) bool { if m1.msg != m2.msg {...

Antonboom

pkg/errors dependency

1

pkg/errors is no longer maintained, cockroachdb/errors still depends on it, will that be an issue down the road. looking for a pkg/errors replacement and just found this project, will start...

laoshaw

Decode context.Canceled, context.DeadlineExceeded etc as a reference to the stdlib instance

1

Currently, instances of the stdlib errors trasnferred over the network are decoded into an object of the same type/value, but not the same instance. So reference comparisons with `==` with...

knz

Add ability to wrap an error with an Unimplemented error

4

I have a bit of code that does something like this: ``` errors.UnimplementedErrorf( link, "unsupported expression %q: %v", exprString, err, ) ``` This flattens the `err` argument. What I'd really...

rafiss

Suggestions

2

For @knz I was looking through the docs trying to find out how to register a migrated error, and it took me a little bit. So I wanted to suggest...

tooolbox