cockpit icon indicating copy to clipboard operation
cockpit copied to clipboard

Published 20 hours ago • verified publisher icon cockpit-project

package.json: Update @patternfly/patternfly, @patternfly/react-core, @patternfly/react-icons, @patternfly/react-styles, @patternfly/react-table

Open github-actions[bot] opened this issue 3 years ago • 3 comments
trafficstars

github-actions[bot] avatar Oct 06 '22 09:10 github-actions[bot]

Please manually check features related to these files:

package.json:    "@patternfly/patternfly": "4.217.1",
package.json:    "@patternfly/react-core": "4.250.1",
package.json:    "@patternfly/react-icons": "4.92.6",
package.json:    "@patternfly/react-styles": "4.91.6",
package.json:    "@patternfly/react-table": "4.111.4",
pkg/apps/application-list.jsx:} from "@patternfly/react-core";
pkg/apps/application-list.jsx:import { RebootingIcon } from "@patternfly/react-icons";
pkg/apps/application.jsx:} from "@patternfly/react-core";
pkg/apps/application.jsx:import { ExternalLinkAltIcon } from '@patternfly/react-icons';
pkg/apps/application.scss:@use "../../node_modules/@patternfly/patternfly/utilities/Text/text.css";
pkg/apps/utils.jsx:import { Button, Progress, Split, SplitItem, Spinner } from "@patternfly/react-core";
pkg/kdump/kdump-view.jsx:} from "@patternfly/react-core";
pkg/kdump/kdump-view.jsx:import { OutlinedQuestionCircleIcon } from "@patternfly/react-icons";
pkg/lib/_global-variables.scss:@import "@patternfly/patternfly/sass-utilities/all";
pkg/lib/cockpit-components-dialog.jsx:import { Alert, Button, Modal, Popover, Spinner } from "@patternfly/react-core";
pkg/lib/cockpit-components-dialog.jsx:import { HelpIcon, ExternalLinkAltIcon } from '@patternfly/react-icons';
pkg/lib/cockpit-components-empty-state.jsx:} from '@patternfly/react-core';
pkg/lib/cockpit-components-file-autocomplete.jsx:import { Select, SelectVariant, SelectOption } from "@patternfly/react-core";
pkg/lib/cockpit-components-firewalld-request.jsx:} from '@patternfly/react-core';
pkg/lib/cockpit-components-firewalld-request.scss:@use "../../node_modules/@patternfly/patternfly/utilities/BoxShadow/box-shadow.css";
pkg/lib/cockpit-components-inline-notification.jsx:import { Alert, AlertActionCloseButton, Button } from '@patternfly/react-core';
pkg/lib/cockpit-components-install-dialog.jsx:import { WarningTriangleIcon } from "@patternfly/react-icons";
pkg/lib/cockpit-components-listing-panel.jsx:import { Tabs, Tab, TabTitleText } from '@patternfly/react-core';
pkg/lib/cockpit-components-logs-panel.jsx:import { Badge, Button, Card, CardHeader, CardActions, CardTitle, CardBody } from '@patternfly/react-core';
pkg/lib/cockpit-components-logs-panel.jsx:import { ExclamationTriangleIcon, TimesCircleIcon } from '@patternfly/react-icons';
pkg/lib/cockpit-components-modifications.jsx:} from '@patternfly/react-core';
pkg/lib/cockpit-components-modifications.jsx:import { CheckIcon, CopyIcon, ExternalLinkAltIcon, OutlinedQuestionCircleIcon } from '@patternfly/react-icons';
pkg/lib/cockpit-components-password.jsx:import { FormGroup, Popover, Progress, ProgressSize, ProgressMeasureLocation, TextInput } from '@patternfly/react-core';
pkg/lib/cockpit-components-password.jsx:import { HelpIcon } from '@patternfly/react-icons';
pkg/lib/cockpit-components-plot.jsx:} from '@patternfly/react-core';
pkg/lib/cockpit-components-plot.jsx:import { AngleLeftIcon, AngleRightIcon, SearchMinusIcon } from '@patternfly/react-icons';
pkg/lib/cockpit-components-plot.jsx:import '@patternfly/patternfly/patternfly-charts.scss';
pkg/lib/cockpit-components-privileged.jsx:import { Button, Tooltip, TooltipPosition } from '@patternfly/react-core';
pkg/lib/cockpit-components-shutdown.jsx:} from '@patternfly/react-core';
pkg/lib/cockpit-components-table.jsx:} from '@patternfly/react-table';
pkg/lib/cockpit-components-table.jsx:} from '@patternfly/react-core';
pkg/lib/cockpit-components-table.scss:@import "@patternfly/patternfly/components/Table/table.scss";
pkg/lib/cockpit-components-table.scss:@import "@patternfly/patternfly/components/Table/table-grid.scss";
pkg/lib/cockpit-components-terminal.jsx:import { Modal, Button } from "@patternfly/react-core";
pkg/lib/page.scss:@use "@patternfly/patternfly/base/patternfly-themes.scss";
pkg/lib/page.scss:@import "@patternfly/patternfly/components/Page/page.scss";
pkg/lib/patternfly/patternfly-4-cockpit.scss:@import "@patternfly/patternfly/patternfly-base.scss";
pkg/lib/serverTime.js:} from '@patternfly/react-core';
pkg/lib/serverTime.js:import { CloseIcon, ExclamationCircleIcon, InfoCircleIcon, PlusIcon } from "@patternfly/react-icons";
pkg/metrics/metrics.jsx:} from '@patternfly/react-core';
pkg/metrics/metrics.jsx:import { Table, TableHeader, TableBody, TableGridBreakpoint, TableVariant, TableText, RowWrapper, cellWidth, fitContent } from '@patternfly/react-table';
pkg/metrics/metrics.jsx:import { ExclamationTriangleIcon, ExclamationCircleIcon, CogIcon, ExternalLinkAltIcon } from '@patternfly/react-icons';
pkg/metrics/metrics.scss:@import "@patternfly/patternfly/utilities/Text/text.scss";
pkg/metrics/metrics.scss:@import "@patternfly/patternfly/utilities/Spacing/spacing.css";
pkg/networkmanager/app.jsx:import { Button } from "@patternfly/react-core";
pkg/networkmanager/app.jsx:import { ExclamationCircleIcon } from "@patternfly/react-icons";
pkg/networkmanager/bond.jsx:} from '@patternfly/react-core';
pkg/networkmanager/bond.jsx:import { ExternalLinkSquareAltIcon, HelpIcon } from '@patternfly/react-icons';
pkg/networkmanager/bridge.jsx:} from '@patternfly/react-core';
pkg/networkmanager/bridgeport.jsx:} from '@patternfly/react-core';
pkg/networkmanager/dialogs-common.jsx:} from '@patternfly/react-core';
pkg/networkmanager/firewall-switch.jsx:import { HelperText, HelperTextItem, Switch, Tooltip } from "@patternfly/react-core";
pkg/networkmanager/firewall.jsx:} from '@patternfly/react-core';
pkg/networkmanager/firewall.jsx:import { ExclamationCircleIcon } from '@patternfly/react-icons';
pkg/networkmanager/interfaces.js:import { Button } from '@patternfly/react-core';
pkg/networkmanager/ip-settings.jsx:} from '@patternfly/react-core';
pkg/networkmanager/ip-settings.jsx:import { MinusIcon, PlusIcon } from '@patternfly/react-icons';
pkg/networkmanager/mac.jsx:} from '@patternfly/react-core';
pkg/networkmanager/mtu.jsx:} from '@patternfly/react-core';
pkg/networkmanager/network-interface-members.jsx:} from '@patternfly/react-core';
pkg/networkmanager/network-interface-members.jsx:import { MinusIcon } from '@patternfly/react-icons';
pkg/networkmanager/network-interface.jsx:} from "@patternfly/react-core";
pkg/networkmanager/network-main.jsx:} from "@patternfly/react-core";
pkg/networkmanager/networking.scss:@import "@patternfly/patternfly/components/Toolbar/toolbar.scss";
pkg/networkmanager/plots.js:import { Split, SplitItem, Grid, GridItem } from '@patternfly/react-core';
pkg/networkmanager/team.jsx:} from '@patternfly/react-core';
pkg/networkmanager/teamport.jsx:} from '@patternfly/react-core';
pkg/networkmanager/vlan.jsx:} from '@patternfly/react-core';
pkg/packagekit/autoupdates.jsx:} from '@patternfly/react-core';
pkg/packagekit/history.jsx:import { Tooltip } from "@patternfly/react-core";
pkg/packagekit/history.jsx:import { BundleIcon } from "@patternfly/react-icons";
pkg/packagekit/kpatch.jsx:} from "@patternfly/react-core";
pkg/packagekit/kpatch.jsx:import { InfoIcon, InfoCircleIcon } from "@patternfly/react-icons";
pkg/packagekit/updates.jsx:} from '@patternfly/react-core';
pkg/packagekit/updates.jsx:} from "@patternfly/react-icons";
pkg/packagekit/updates.jsx:import { cellWidth, TableText } from "@patternfly/react-table";
pkg/packagekit/updates.scss:@import "@patternfly/patternfly/utilities/Spacing/spacing.css";
pkg/playground/index.js:import "../../node_modules/@patternfly/patternfly/components/Button/button.css";
pkg/playground/journal.jsx:import "../../node_modules/@patternfly/patternfly/components/Page/page.css";
pkg/playground/react-demo-cards.jsx:} from '@patternfly/react-core';
pkg/playground/react-demo-dialog.jsx:import { Form, FormGroup, TextInput } from "@patternfly/react-core";
pkg/playground/react-patterns.js:import "../../node_modules/@patternfly/patternfly/components/Page/page.css";
pkg/playground/speed.js:import "../../node_modules/@patternfly/patternfly/components/Button/button.css";
pkg/playground/speed.js:import "../../node_modules/@patternfly/patternfly/components/Page/page.css";
pkg/playground/test.js:import "../../node_modules/@patternfly/patternfly/components/Button/button.css";
pkg/playground/test.js:import "../../node_modules/@patternfly/patternfly/components/Page/page.css";
pkg/selinux/setroubleshoot-view.jsx:} from "@patternfly/react-core";
pkg/selinux/setroubleshoot-view.jsx:import { ExclamationCircleIcon, ExclamationTriangleIcon, InfoCircleIcon } from "@patternfly/react-icons";
pkg/shell/active-pages-modal.jsx:import { Button, Label, Split, SplitItem, Modal } from '@patternfly/react-core';
pkg/shell/credentials.jsx:} from '@patternfly/react-core';
pkg/shell/credentials.jsx:import { InfoCircleIcon } from '@patternfly/react-icons';
pkg/shell/failures.jsx:import { Button, ClipboardCopy, Page, PageSection, PageSectionVariants, Stack } from "@patternfly/react-core";
pkg/shell/failures.jsx:import { ExclamationCircleIcon } from "@patternfly/react-icons";
pkg/shell/hosts.jsx:import { PageSidebar, Button, Tooltip } from '@patternfly/react-core';
pkg/shell/hosts.jsx:import { EditIcon, MinusIcon, CaretUpIcon, CaretDownIcon } from '@patternfly/react-icons';
pkg/shell/hosts.jsx:import "../../node_modules/@patternfly/patternfly/components/Select/select.css";
pkg/shell/hosts_dialog.jsx:} from '@patternfly/react-core';
pkg/shell/nav.jsx:} from '@patternfly/react-core';
pkg/shell/nav.jsx:import { ContainerNodeIcon, ExclamationCircleIcon, ExclamationTriangleIcon, InfoCircleIcon } from '@patternfly/react-icons';
pkg/shell/nav.scss:@import "@patternfly/patternfly/components/Toolbar/toolbar.scss";
pkg/shell/shell-modals.jsx:} from '@patternfly/react-core';
pkg/shell/superuser.jsx:import { Alert, Button, Form, FormGroup, Modal, TextInput, FormSelect, FormSelectOption } from '@patternfly/react-core';
pkg/shell/superuser.jsx:import { LockIcon } from '@patternfly/react-icons';
pkg/shell/topnav.jsx:} from '@patternfly/react-core';
pkg/shell/topnav.jsx:import { CogIcon, ExternalLinkAltIcon, HelpIcon } from '@patternfly/react-icons';
pkg/sosreport/index.jsx:} from "@patternfly/react-core";
pkg/sosreport/index.jsx:import { EyeIcon, EyeSlashIcon } from '@patternfly/react-icons';
pkg/sosreport/sosreport.scss:@use "../../node_modules/@patternfly/patternfly/utilities/Text/text.css";
pkg/storaged/block-details.jsx:} from "@patternfly/react-core";
pkg/storaged/content-views.jsx:} from "@patternfly/react-core";
pkg/storaged/content-views.jsx:import { ExclamationTriangleIcon } from "@patternfly/react-icons";
pkg/storaged/crypto-keyslots.jsx:} from "@patternfly/react-core";
pkg/storaged/crypto-keyslots.jsx:import { EditIcon, MinusIcon, PlusIcon } from "@patternfly/react-icons";
pkg/storaged/crypto-panel.jsx:import { SortByDirection } from '@patternfly/react-table';
pkg/storaged/crypto-tab.jsx:} from "@patternfly/react-core";
pkg/storaged/details.jsx:import { Page, PageSection, Grid, GridItem, Breadcrumb, BreadcrumbItem, Flex, FlexItem } from "@patternfly/react-core";
pkg/storaged/devices.jsx:import { ExclamationCircleIcon } from "@patternfly/react-icons";
pkg/storaged/dialog.jsx:} from "@patternfly/react-core";
pkg/storaged/dialog.jsx:import { ExclamationTriangleIcon, InfoIcon, HelpIcon } from "@patternfly/react-icons";
pkg/storaged/drive-details.jsx:} from "@patternfly/react-core";
pkg/storaged/fsys-panel.jsx:import { SortByDirection } from '@patternfly/react-table';
pkg/storaged/fsys-tab.jsx:} from "@patternfly/react-core";
pkg/storaged/iscsi-panel.jsx:import { Button } from "@patternfly/react-core";
pkg/storaged/iscsi-panel.jsx:import { CheckIcon, EditIcon, PlusIcon, TrashIcon } from "@patternfly/react-icons";
pkg/storaged/jobs-panel.jsx:} from "@patternfly/react-core";
pkg/storaged/lvol-tabs.jsx:} from "@patternfly/react-core";
pkg/storaged/mdraid-details.jsx:} from "@patternfly/react-core";
pkg/storaged/mdraid-details.jsx:import { MinusIcon, PlusIcon } from "@patternfly/react-icons";
pkg/storaged/multipath.jsx:} from "@patternfly/react-core";
pkg/storaged/nfs-details.jsx:} from "@patternfly/react-core";
pkg/storaged/nfs-panel.jsx:import { SortByDirection } from '@patternfly/react-table';
pkg/storaged/nfs-panel.jsx:import { PlusIcon } from '@patternfly/react-icons';
pkg/storaged/optional-panel.jsx:} from "@patternfly/react-core";
pkg/storaged/overview.jsx:import { Page, PageSection, Grid, GridItem, Card, CardBody, Gallery } from "@patternfly/react-core";
pkg/storaged/part-tab.jsx:} from "@patternfly/react-core";
pkg/storaged/plot.jsx:import { Split, SplitItem, Grid, GridItem } from '@patternfly/react-core';
pkg/storaged/pvol-tabs.jsx:} from "@patternfly/react-core";
pkg/storaged/side-panel.jsx:import { Button, Spinner, EmptyState, EmptyStateVariant, EmptyStateBody, Flex, FlexItem } from '@patternfly/react-core';
pkg/storaged/side-panel.jsx:import { ExclamationTriangleIcon } from '@patternfly/react-icons';
pkg/storaged/storage-controls.jsx:} from '@patternfly/react-core';
pkg/storaged/storage-controls.jsx:import { BarsIcon } from '@patternfly/react-icons';
pkg/storaged/storage-controls.jsx:import '@patternfly/react-styles/css/components/Progress/progress.css';
pkg/storaged/storage.scss:@import "@patternfly/patternfly/components/Card/card.scss";
pkg/storaged/storage.scss:@import "@patternfly/patternfly/utilities/Flex/flex.scss";
pkg/storaged/storage.scss:@import "@patternfly/patternfly/utilities/Text/text.scss";
pkg/storaged/stratis-details.jsx:} from "@patternfly/react-core";
pkg/storaged/stratis-details.jsx:import { PlusIcon, ExclamationTriangleIcon } from "@patternfly/react-icons";
pkg/storaged/stratis-panel.jsx:import { UnlockIcon } from "@patternfly/react-icons";
pkg/storaged/swap-tab.jsx:} from "@patternfly/react-core";
pkg/storaged/unrecognized-tab.jsx:} from "@patternfly/react-core";
pkg/storaged/vdo-details.jsx:} from "@patternfly/react-core";
pkg/storaged/vgroup-details.jsx:} from "@patternfly/react-core";
pkg/storaged/vgroup-details.jsx:import { PlusIcon, MinusIcon } from "@patternfly/react-icons";
pkg/systemd/abrtLog.jsx:} from '@patternfly/react-core';
pkg/systemd/hwinfo.jsx:} from '@patternfly/react-core';
pkg/systemd/hwinfo.jsx:import { ExternalLinkAltIcon } from "@patternfly/react-icons";
pkg/systemd/hwinfo.jsx:import { SortByDirection } from "@patternfly/react-table";
pkg/systemd/logDetails.jsx:import { ExclamationCircleIcon } from '@patternfly/react-icons';
pkg/systemd/logDetails.jsx:} from '@patternfly/react-core';
pkg/systemd/logs.jsx:} from "@patternfly/react-core";
pkg/systemd/logs.jsx:} from '@patternfly/react-icons';
pkg/systemd/logs.scss:@import "@patternfly/patternfly/components/Toolbar/toolbar.scss";
pkg/systemd/logs.scss:@import "@patternfly/patternfly/utilities/Flex/flex.scss";
pkg/systemd/logsJournal.jsx:import { Alert, AlertActionCloseButton } from '@patternfly/react-core';
pkg/systemd/logsJournal.jsx:import { ExclamationCircleIcon } from '@patternfly/react-icons';
pkg/systemd/overview-cards/configurationCard.jsx:} from '@patternfly/react-core';
pkg/systemd/overview-cards/cryptoPolicies.jsx:import { Button, Flex, FlexItem, Modal, Popover } from "@patternfly/react-core";
pkg/systemd/overview-cards/cryptoPolicies.jsx:import { ExclamationTriangleIcon, ExternalLinkSquareAltIcon, HelpIcon } from '@patternfly/react-icons';
pkg/systemd/overview-cards/healthCard.jsx:import { Card, CardBody, CardFooter, CardTitle } from '@patternfly/react-core';
pkg/systemd/overview-cards/insights.jsx:import { Button, Flex } from '@patternfly/react-core';
pkg/systemd/overview-cards/insights.jsx:import { CheckIcon, ExclamationTriangleIcon, ExternalLinkAltIcon } from '@patternfly/react-icons';
pkg/systemd/overview-cards/lastLogin.jsx:import { Button, Flex, FlexItem } from '@patternfly/react-core';
pkg/systemd/overview-cards/lastLogin.jsx:import { ExclamationTriangleIcon, UserIcon } from "@patternfly/react-icons";
pkg/systemd/overview-cards/lastLogin.scss:@import "@patternfly/patternfly/utilities/Text/text.scss";
pkg/systemd/overview-cards/motdCard.jsx:import { Alert, AlertActionCloseButton, Button, Modal, TextArea } from '@patternfly/react-core';
pkg/systemd/overview-cards/motdCard.jsx:import { EditIcon } from '@patternfly/react-icons';
pkg/systemd/overview-cards/profiles-menu-dialog-body.jsx:import { Label, LabelGroup, Menu, MenuItem, MenuContent, MenuList, Flex, FlexItem } from '@patternfly/react-core';
pkg/systemd/overview-cards/realmd.jsx:} from '@patternfly/react-core';
pkg/systemd/overview-cards/realmd.jsx:import { CheckIcon, ExclamationCircleIcon, InProgressIcon } from "@patternfly/react-icons";
pkg/systemd/overview-cards/shutdownStatus.jsx:import { Button, Flex, FlexItem } from '@patternfly/react-core';
pkg/systemd/overview-cards/shutdownStatus.jsx:import { PowerOffIcon, RedoIcon } from "@patternfly/react-icons";
pkg/systemd/overview-cards/systemInformationCard.jsx:import { Button, Card, CardBody, CardFooter, CardTitle } from '@patternfly/react-core';
pkg/systemd/overview-cards/usageCard.jsx:} from '@patternfly/react-core';
pkg/systemd/overview.jsx:} from '@patternfly/react-core';
pkg/systemd/overview.scss:@import "@patternfly/patternfly/components/Table/table.scss";
pkg/systemd/page-status.jsx:import { Button, Flex, Spinner } from "@patternfly/react-core";
pkg/systemd/page-status.jsx:} from '@patternfly/react-icons';
pkg/systemd/reporting.jsx:import { Button, Card, CardBody, CardTitle, Split, SplitItem, Spinner } from "@patternfly/react-core";
pkg/systemd/reporting.jsx:import { ExternalLinkAltIcon } from "@patternfly/react-icons";
pkg/systemd/services/service-details.jsx:} from "@patternfly/react-core";
pkg/systemd/services/service-details.jsx:} from "@patternfly/react-icons";
pkg/systemd/services/service-tabs.jsx:import { Button, Nav, NavList, NavItem } from '@patternfly/react-core';
pkg/systemd/services/service-tabs.jsx:import { ExclamationCircleIcon } from '@patternfly/react-icons';
pkg/systemd/services/service.jsx:} from '@patternfly/react-core';
pkg/systemd/services/services-list.jsx:} from '@patternfly/react-core';
pkg/systemd/services/services-list.jsx:import { ExclamationCircleIcon, ThumbtackIcon } from '@patternfly/react-icons';
pkg/systemd/services/services.jsx:} from '@patternfly/react-core';
pkg/systemd/services/services.jsx:import { SearchIcon, ExclamationCircleIcon, FilterIcon } from '@patternfly/react-icons';
pkg/systemd/services/services.scss:@import "@patternfly/patternfly/components/Toolbar/toolbar.scss";
pkg/systemd/services/timer-dialog.jsx:} from '@patternfly/react-core';
pkg/systemd/services/timer-dialog.jsx:import { MinusIcon, PlusIcon } from '@patternfly/react-icons';
pkg/systemd/superuser-alert.jsx:import { Alert } from '@patternfly/react-core';
pkg/systemd/superuser-alert.jsx:import { LockIcon } from '@patternfly/react-icons';
pkg/systemd/terminal.jsx:} from "@patternfly/react-core";
pkg/systemd/terminal.scss:@import "@patternfly/patternfly/components/Toolbar/toolbar.scss";
pkg/tuned/dialog.jsx:import { Button, Modal, Popover, Tooltip } from "@patternfly/react-core";
pkg/tuned/dialog.jsx:import { ExternalLinkSquareAltIcon, HelpIcon } from '@patternfly/react-icons';
pkg/users/account-create-dialog.js:import { Checkbox, Form, FormGroup, TextInput, Popover, Flex, FlexItem, Radio } from '@patternfly/react-core';
pkg/users/account-create-dialog.js:import { HelpIcon } from '@patternfly/react-icons';
pkg/users/account-details.js:} from '@patternfly/react-core';
pkg/users/account-details.js:import { ExclamationCircleIcon, HelpIcon } from '@patternfly/react-icons';
pkg/users/account-logs-panel.jsx:import { Card, CardTitle, CardBody, Text } from '@patternfly/react-core';
pkg/users/account-roles.js:import { Alert, Checkbox, Flex, Tooltip, TooltipPosition } from '@patternfly/react-core';
pkg/users/account-roles.js:import { OutlinedQuestionCircleIcon } from '@patternfly/react-icons';
pkg/users/accounts-list.js:import { Button, Badge, Card, CardBody, Gallery, Page, PageSection, PageSectionVariants } from '@patternfly/react-core';
pkg/users/accounts-list.js:import { UserIcon } from '@patternfly/react-icons';
pkg/users/authorized-keys-panel.js:import { Button, TextArea } from '@patternfly/react-core';
pkg/users/delete-account-dialog.js:import { Checkbox } from '@patternfly/react-core';
pkg/users/expiration-dialogs.js:import { Flex, Form, FormGroup, FormHelperText, Radio, TextInput, DatePicker } from '@patternfly/react-core';
pkg/users/password-dialogs.js:import { Form, FormGroup, TextInput } from '@patternfly/react-core';
pkg/users/users.scss:@import "@patternfly/patternfly/utilities/Spacing/spacing.css";
pkg/users/users.scss:@import "@patternfly/patternfly/components/DataList/data-list.scss";
webpack.config.js:        from: path.resolve(nodedir, '@patternfly/patternfly/assets/fonts', subdir, 'RedHat' + name + '.woff2'),
webpack.config.js:                        stylesheet.includes('@patternfly/react-styles/css/components/Table/') ||
webpack.config.js:                        stylesheet.includes('@patternfly/react-styles/css/components/Page/') ||
webpack.config.js:                        stylesheet.includes('@patternfly/react-styles/css/components/Toolbar/')

github-actions[bot] avatar Oct 06 '22 09:10 github-actions[bot]

Hopefully this one passes the tests.

I'm testing it manually and haven't seen the page header height / padding problem.

But I do see inconsistent page headers, which isn't really a recent regression. (It's been like this on main and in Cockpit releases for some time.) So we'll probably will still want the CSS from https://github.com/cockpit-project/cockpit/pull/17649#issuecomment-1218265417, but it could be a separate PR, as it now fixes the page headers in ways unrelated to this PR.

garrett avatar Oct 06 '22 09:10 garrett

@marusak during the PatternFly meeting yesterday it was noted that a new PF was released possibly with the fixes we want for the dark theme. Not sure if a refresh might be useful.

jelly avatar Oct 13 '22 12:10 jelly

@garrett we need to check failed pixel test and decide if they are correct or if they are regressions we need to deal with. Can you please take a look?

marusak avatar Oct 19 '22 08:10 marusak

Can you please take a look?

Sure. Where are the screenshot tests?

I looked at the screenshots at https://cockpit-logs.us-east-1.linodeobjects.com/pull-17795-20221013-121141-f3ff12b9-fedora-37/log.html (f37) and https://cockpit-logs.us-east-1.linodeobjects.com/pull-17795-20221013-121141-f3ff12b9-rhel-9-2/log.html (rhel 9.2) and they all seemed fine at a glance... but there's no comparison with new/old, so I guess it's not the right place?

garrett avatar Oct 19 '22 10:10 garrett

See changed pixels in https://cockpit-logs.us-east-1.linodeobjects.com/pull-17795-20221013-121141-f3ff12b9-fedora-36/log.html

From a quick look I took it seems that mostly card titles are somewhat different.

marusak avatar Oct 19 '22 16:10 marusak

See changed pixels in https://cockpit-logs.us-east-1.linodeobjects.com/pull-17795-20221013-121141-f3ff12b9-fedora-36/log.html

From a quick look I took it seems that mostly card titles are somewhat different.

That sounds like: https://github.com/patternfly/patternfly/pull/5069

jelly avatar Oct 19 '22 18:10 jelly

Yeah, @jelly and I talked about this on IRC last night: we need to undo the undo and use Red Hat Display for the heading fonts, but that should be a unified push in this release. (It's not noteworthy of a release note, fwiw.)

I do see that the headings do change in this PR too @ https://cockpit-logs.us-east-1.linodeobjects.com/pull-17795-20221013-121141-f3ff12b9-fedora-36/pixeldiff.html#TestServices-testBasic-text-filter-test-mobile, so we'll want to make sure that fix I proposed is added as well.

garrett avatar Oct 20 '22 11:10 garrett

Pixel diffs: https://github.com/cockpit-project/pixel-test-reference/compare/148b02a3b4e310debfefd18b12843a61d42ad9c1..5c3d44439793183286a4ece3fb2eac799edcc0ee

marusak avatar Oct 20 '22 13:10 marusak

OK, I went through that HUGE list of differences and it all looks good! Let's merge. :partying_face:

(Next step: Let's try out whatever version fixes dark theme. But that's after this PR; probably on Monday or so, according to our meeting today. This PR is good!)

garrett avatar Oct 20 '22 14:10 garrett

Two tests are affected: packagekit does not see any icons abrt does not see <a> element

These might be related to some changes in PF components. I will take a look

marusak avatar Oct 21 '22 06:10 marusak