cmssw

cmssw copied to clipboard

PR description:

Porting local https://github.com/cms-l1t-offline/cmssw/pull/1015

This PR contains all the improvements in the track jet code and the improved tagging of displaced jets (and their selection): The work was presented in many GTT through the years but a summary is also presented in the last GTT meeting: https://indico.cern.ch/event/1146596/

Several bug fixes are included and also an optimization of the code itself that makes the code 2 times faster than before. In the last slide there is a validation of the improved code.

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-38337/30515

• This PR adds an extra 24KB to repository

Code check has found code style and quality issues which could be resolved by applying following patch(s)

• code-format: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-38337/30515/code-format.patch e.g. curl -k https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-38337/30515/code-format.patch | patch -p1 You can also run scram build code-format to apply code format directly

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-38337/30516

• This PR adds an extra 24KB to repository

Code check has found code style and quality issues which could be resolved by applying following patch(s)

• code-format: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-38337/30516/code-format.patch e.g. curl -k https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-38337/30516/code-format.patch | patch -p1 You can also run scram build code-format to apply code format directly

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-38337/30517

• This PR adds an extra 24KB to repository

A new Pull Request was created by @cecilecaillol for master.

It involves the following packages:

• L1Trigger/L1TTrackMatch (upgrade, l1)

@rekovic, @epalencia, @cmsbuild, @AdrianoDee, @srimanob, @cecilecaillol can you please review it and eventually sign? Thanks. @Martin-Grunewald, @missirol, @beaucero, @trtomei this is something you requested to watch as well. @perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

please test

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-e6ddd2/25450/summary.html COMMIT: b95aea3071c41993d2b8099b41279944b7008a23 CMSSW: CMSSW_12_5_X_2022-06-11-1100/el8_amd64_gcc10 User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/38337/25450/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 2 differences found in the comparisons
• DQMHistoTests: Total files compared: 50
• DQMHistoTests: Total histograms compared: 3658678
• DQMHistoTests: Total failures: 8
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3658648
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 49 files compared)
• Checked 208 log files, 45 edm output root files, 50 DQM output files
• TriggerResults: no differences found

+l1

@cmsbuild please test

Refresh the test again.

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-e6ddd2/25936/summary.html COMMIT: b95aea3071c41993d2b8099b41279944b7008a23 CMSSW: CMSSW_12_5_X_2022-07-01-1100/el8_amd64_gcc10 User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/38337/25936/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 50
• DQMHistoTests: Total histograms compared: 3654771
• DQMHistoTests: Total failures: 2
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3654747
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 49 files compared)
• Checked 208 log files, 45 edm output root files, 50 DQM output files
• TriggerResults: no differences found

Also: is there a wf where we may test these updates?

@cms-sw/l1-l2 Do you have responses from @AdrianoDee comment? Thanks.

@cecilecaillol @AdrianoDee Do we find the conclusion for this PR?

Hi @cms-sw/l1-l2 Is this PR needed for 12_5 production?

Hi @srimanob, no, it is not strictly needed.

hold

• waiting for comments to be addressed
• not needed for 12_5 production

Pull request has been put on hold by @AdrianoDee They need to issue an unhold command to remove the hold state or L1 can unhold it for all

A comment mostly for for @gkaratha , and @BenjaminRS: we decided that this is not needed for the MC production, cause the L1 sequence for this MC production aims at replacing the simulation with the emulation. You left the simulation code in for trackJets and trackVertex because you need it for developments, but updates to the simulation will not affect what we will run in the production.

Hi @cbotta . thanks for the notice. In that case we will propagate the improvements to the emulation for later usage.

Best, george

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-38337/31948

• This PR adds an extra 12KB to repository

• There are other open Pull requests which might conflict with changes you have proposed:

  • File L1Trigger/L1TTrackMatch/python/L1TrackJetProducer_cfi.py modified in PR(s): #39244

Pull request #38337 was updated. @rekovic, @epalencia, @cmsbuild, @AdrianoDee, @srimanob, @cecilecaillol can you please check and sign again.

@gkaratha I have rebased the PR and applied Adriano's comments (except "Is there a reason for this change in the parameter initialization " -> can you please reply?). Can you please check everything makes sense?

@srimanob @AdrianoDee We would like this PR to be backported to 12_5 for our MC production. Can you please unhold the PR?

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-38337/31949

• This PR adds an extra 20KB to repository

• Found files with invalid states:

  • L1Trigger/L1TTrackMatch/plugins/L1TrackJetProducer.h:
    • Added: 8dff76646348acdcbd9526a5cb1cf221122c232f
    • Modified: 5f66da07efeb97198e93f7b7076fff1713d6e36d, 44cddd2b4277aa74a77cc57e8ea3495b5f2c50ad
    • Deleted: e1eb86577c7f682ae59856b48324bb3c3daabd5d

• There are other open Pull requests which might conflict with changes you have proposed:

  • File L1Trigger/L1TTrackMatch/python/L1TrackJetProducer_cfi.py modified in PR(s): #39244

Pull request #38337 was updated. @rekovic, @epalencia, @cmsbuild, @AdrianoDee, @srimanob, @cecilecaillol can you please check and sign again.

please test

@srimanob @AdrianoDee We would like this PR to be backported to 12_5 for our MC production. Can you please unhold the PR?

@cecilecaillol does this comply with what written by @cbotta in https://github.com/cms-sw/cmssw/pull/38337#issuecomment-1223876844?

@srimanob @AdrianoDee We would like this PR to be backported to 12_5 for our MC production. Can you please unhold the PR?

@cecilecaillol does this comply with what written by @cbotta in #38337 (comment)?

We discussed this with @cbotta yesterday and we would like this PR included in 12_5. We also would like https://github.com/cms-sw/cmssw/pull/38334 to be in (to be reopened and needs some work)

please test

-1

Failed Tests: HeaderConsistency Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-e6ddd2/27370/summary.html COMMIT: e1eb86577c7f682ae59856b48324bb3c3daabd5d CMSSW: CMSSW_12_6_X_2022-09-06-1100/el8_amd64_gcc10 User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/38337/27370/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 51
• DQMHistoTests: Total histograms compared: 3618210
• DQMHistoTests: Total failures: 2
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3618186
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 50 files compared)
• Checked 212 log files, 49 edm output root files, 51 DQM output files
• TriggerResults: no differences found

@gkaratha I have rebased the PR and applied Adriano's comments (except "Is there a reason for this change in the parameter initialization " -> can you please reply?). Can you please check everything makes sense?

@srimanob @AdrianoDee We would like this PR to be backported to 12_5 for our MC production. Can you please unhold the PR?

Thanks for adding me in the thread. The tests are failing with header consistency. Is that something we should fix?

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-38337/32100

• This PR adds an extra 16KB to repository

• Found files with invalid states:

  • L1Trigger/L1TTrackMatch/plugins/L1TrackJetProducer.h:
    • Added: 834a2df7dcc2994cb808dd2018d971faafbc2748
    • Modified: 4e8b4b038c29c5de21f9b465090e9766d03504a8, ef80134294fce48bff55af688596a00c31027ec5
    • Deleted: 626df8f92723e833e255a81ff9408b95e6cfd7c9