sdp-transform
sdp-transform copied to clipboard
Adding grammar for precondition a attributes
Hi, I've just added the required grammar for parsing precondition a attributes based on RFC 3312.
Sample:
v=0
.....
a=curr:qos local none
a=curr:qos remote none
a=des:qos mandatory local sendrecv
a=des:qos none remote sendrecv
a=sendrecv
.....
I added parse and write tests for precondition added grammar.
Thanks for this. This looks great to me.
Now for the awkward part. It's actually been a while since I've had to do a release on this, and travis has shutdown since :| Will need to spend some time to fixup CI now.
Hi Eirik, I've just added the MRCP attributes support as well (grammar + test).
Hey, i've updated testing setup now, if you're able to update (nm, i can do it from here) - and it's all green - i can try to push this out later :-)
Codecov Report
Merging #100 (aa4ca13) into master (92dd9d4) will increase coverage by
0.18%. Report is 2 commits behind head on master. The diff coverage is100.00%.
@@ Coverage Diff @@
## master #100 +/- ##
==========================================
+ Coverage 93.60% 93.78% +0.18%
==========================================
Files 4 4
Lines 172 177 +5
==========================================
+ Hits 161 166 +5
Misses 11 11
| Files Changed | Coverage |
|---|---|
| lib/grammar.js | 100.00% |