Eirik A
Eirik A
It's also possible that we can simplify how we implement `Resource` so that you can use `Api` as long as we can `impl Resource for MyMetricType where DynamicType = GroupVersionKind`...
Yeah, I think there are sufficiently short workarounds at the moment; create structs as above, `impl kube::Resource` in your source, or use it dynamically with an `ApiResource`. Going to mark...
We do actually grab the metrics structs in the new prototype [k8s-pb repo](https://github.com/kube-rs/k8s-pb/tree/main/k8s-pb/src/metrics). So we will have support for this once we get the protobuf issue #371 resolved. Absolutely no...
Only reference to it i see was removed from the repo. Following the trail: - https://github.com/kubernetes/metrics/commit/3f16cd9d9a9a7fa1fd9bcc3756d9f399e99af870 - https://github.com/kubernetes/kubernetes/pull/53441 - https://github.com/kubernetes/kubernetes/issues/44589 Not sure if that's even relevant.
Maybe it's one of those structs that are only ever generated by the metrics-server and so we don't have it on disk. Maybe it needs to be run through https://github.com/kubernetes/kube-openapi...
It should not be required to pass in a cluster scoped `Api`. Where are you getting this assumption from? `Controller::owns` should inherit the scope of the `Api` you pass in...
Yeah, even in `client-go` operations like `drain` and `cordon` are not among [its core verbs](https://github.com/kubernetes/client-go/blob/f6ce18ae578c8cca64d14ab9687824d9e1305a67/kubernetes/typed/core/v1/node.go#L42-L56). These "operations" are just `kubectl` helpers: [cordon.go](https://github.com/kubernetes/kubectl/blob/652881798563c00c1895ded6ced819030bfaa4d7/pkg/drain/cordon.go) + [drain.go](https://github.com/kubernetes/kubectl/blob/652881798563c00c1895ded6ced819030bfaa4d7/pkg/drain/drain.go) I'm ok with having `drain` +...
#762 now adds `Api::cordon` and `Api::uncordon` thanks to @ChinYing-Li :tada: The only thing left here is an example for `Api::drain`. As it stands currently herein, this is non-trivial to unit-test...
1. ooh, yeah, good call. we should implement this for `DynamicObject` initially :-) 2. value is a strinigfied bool or tri-bool (possibly more), see https://docs.rs/k8s-openapi/0.13.1/k8s_openapi/api/apiserverinternal/v1alpha1/struct.StorageVersionCondition.html#structfield.status 3. yeah, a combinator there...
I guess some controllers store spec hashes somewhere. Maybe that's to avoid doing the work multiple times. If controllers can do that then at least there are solutions.