bigQueryR icon indicating copy to clipboard operation
bigQueryR copied to clipboard

add location param to bqr_get_job

Open ekocsis3 opened this issue 4 years ago • 1 comments

Hi @MarkEdmondson1234,

Here is my implementation of the bqr_get_job location param as discussed in issue #71. The location is either parsed from the job object or takes the user input. NULL value is accepted for backward compatibility, which still works for EU and US location. Within the package job location is passed to the function whenever it is called.

I didn't add any tests as it would require datasets in a different location, but it worked in my 'testing environment'.

Cheers, Eszter

ekocsis3 avatar Apr 26 '21 15:04 ekocsis3

Thanks! Will take a look. Please do add yourself as a contributor to the Authors in the DESCRIPTION as well if you wish.

MarkEdmondson1234 avatar Apr 26 '21 17:04 MarkEdmondson1234

@MarkEdmondson1234 could you pull this branch in please? We are moving to specific regions (low CO2) now, making this a necessary change.

emilmahler avatar May 20 '24 14:05 emilmahler