hertz icon indicating copy to clipboard operation
hertz copied to clipboard

Published 20 hours ago • verified publisher icon cloudwego

optimize: Add the server.WithBasePath function

Open springrain opened this issue 3 years ago • 1 comments

What type of PR is this?

optimize

Check the PR title.

  • [x] This PR title match the format: <type>(optional scope): <description>
  • [x] The description of this PR title is user-oriented and clear enough for others to understand.

(Optional) Translate the PR title into Chinese.

增加server.WithBasePath函数

(Optional) More detail description for this PR(en: English/zh: Chinese).

en: Similar to the java web's contextPath, it is convenient for nginx distribution zh: 类似java web的contextPath,方便nginx分发

springrain avatar Oct 17 '22 12:10 springrain

Codecov Report

Base: 69.68% // Head: 69.62% // Decreases project coverage by -0.06% :warning:

Coverage data is based on head (2ff65ca) compared to base (7895df7). Patch coverage: 77.77% of modified lines in pull request are covered.

Additional details and impacted files 
@@             Coverage Diff             @@
##           develop     #303      +/-   ##
===========================================
- Coverage    69.68%   69.62%   -0.07%     
===========================================
  Files           93       93              
  Lines         8752     8760       +8     
===========================================
  Hits          6099     6099              
- Misses        2292     2298       +6     
- Partials       361      363       +2
Impacted Files Coverage Δ
pkg/app/server/option.go 98.55% <71.42%> (-1.45%) :arrow_down:
pkg/common/config/option.go 100.00% <100.00%> (ø)
pkg/route/engine.go 63.19% <100.00%> (ø)
pkg/common/timer/timer.go 61.90% <0.00%> (-19.05%) :arrow_down:
pkg/app/client/client.go 73.41% <0.00%> (-1.27%) :arrow_down:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

codecov[bot] avatar Oct 17 '22 13:10 codecov[bot]

lint needs to be fixed 🙏 Run gofumpt -l -extra . to check.

welkeyever avatar Nov 10 '22 07:11 welkeyever

CLA assistant check
All committers have signed the CLA.

CLAassistant avatar Nov 22 '22 06:11 CLAassistant

Please resign the CLA🙏

welkeyever avatar Nov 22 '22 06:11 welkeyever

lint needs to be fixed 🙏 Run gofumpt -l -extra . to check.

I have already executed the command locally and there is no problem, I don't know why the check still fails. Please help to modify the code format, thank you very much

springrain avatar Dec 05 '22 05:12 springrain

lint needs to be fixed 🙏 Run gofumpt -l -extra . to check.

I have already executed the command locally and there is no problem, I don't know why the check still fails. Please help to modify the code format, thank you very much

ok

li-jin-gou avatar Dec 08 '22 15:12 li-jin-gou

lint needs to be fixed 🙏 Run gofumpt -l -extra . to check.

I have already executed the command locally and there is no problem, I don't know why the check still fails. Please help to modify the code format, thank you very much

Done and i use gofumpt -e -d -w -extra .

li-jin-gou avatar Dec 18 '22 14:12 li-jin-gou

LGTM

li-jin-gou avatar Dec 21 '22 03:12 li-jin-gou