terraform-aws-ecs-alb-service-task icon indicating copy to clipboard operation
terraform-aws-ecs-alb-service-task copied to clipboard

Published 20 hours ago • verified publisher icon cloudposse

feat: adds ignore changes on load balancer option

Open jbrt opened this issue 2 years ago • 4 comments

what

Adds a new input variable ignore_changes_load_balancer.

why

When using this module within an AWS CodeDeploy Blue/Green deployment context, we need a way to ignore changes related to Load Balancers / Target Groups to avoid any drift. That's why the PR adds a ignore_changes_load_balancer input variable.

references

Cloudposse's TF modules used for testing: https://registry.terraform.io/modules/cloudposse/ecs-alb-service-task/aws/latest https://registry.terraform.io/modules/cloudposse/alb/aws/latest https://registry.terraform.io/modules/cloudposse/code-deploy/aws/latest

jbrt avatar May 23 '23 07:05 jbrt

Hello 👋

@srhopkins @korenyoni can you please review this PR ? ;)

Regards

jbrt avatar Jun 02 '23 06:06 jbrt

/terratest

hans-d avatar Mar 02 '24 17:03 hans-d

@jbrt Hi, can you update the pr so that it passes the tests? otherwise, it is likely to be closed due to staleness.

hans-d avatar Mar 03 '24 13:03 hans-d

Thanks @jbrt for creating this pull request!

A maintainer will review your changes shortly. Please don't be discouraged if it takes a while.

While you wait, make sure to review our contributor guidelines.

[!TIP]

Need help or want to ask for a PR review to be expedited?

Join us on Slack in the #pr-reviews channel.

mergify[bot] avatar Mar 09 '24 04:03 mergify[bot]