Summary

Fixes #715.

Checklist:

Please check each of the boxes below for which you have completed the corresponding task:

• [x] I have performed a self-review of my own code
• [x] I have commented my code, particularly in hard-to-understand areas
• [x] I have added tests that prove my fix is effective or that my feature works
• [x] All unit tests pass locally (after my changes)
• [x] Rubocop reports zero errors (after my changes)

Please include below the summary portions of the output from the following 2 scripts:

pushd src/bosh_azure_cpi
  bundle install
  bundle exec rake spec:unit
  bundle exec rake rubocop
popd

NOTE: Please see how to setup dev environment and run unit tests in docs/development.md.

Unit Test output:

$ bundle exec rspec spec/unit
......................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................
...........................................................................................................................................................................................................................................................

Finished in 4.95 seconds (files took 2 seconds to load)
1105 examples, 0 failures

Coverage report generated for RSpec to /workspaces/bosh-azure-cpi-release/src/bosh_azure_cpi/coverage.
Line Coverage: 49.45% (20239 / 40927)

Rubocop output:

(TODO: Paste rubocop script summary output here)

Changelog

• Use the Azure API to decided whether to use Premium or Standard storage for the default disk type
• Use the Azure API to determine suitable instance types for the calculation of the vm cloud properties
• NOTICE: This change might impact your deployment if your deployment manifest does not specifically set a disk type and your are using an instance type that is not matched by this regular expression.