workers-sdk icon indicating copy to clipboard operation
workers-sdk copied to clipboard

Log all accessible ports on remote mode dev

Open Skye-31 opened this issue 3 years ago • 5 comments

Closes #1652 Uses borrowed logic from miniflare

Skye-31 avatar Sep 18 '22 16:09 Skye-31

🦋 Changeset detected

Latest commit: 1c699d12ebb672ab899bb1d51ac01ccf0289723f

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
wrangler Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

changeset-bot[bot] avatar Sep 18 '22 16:09 changeset-bot[bot]

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.developers.workers.dev/runs/3083726244/npm-package-wrangler-1881

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.developers.workers.dev/prs/1881/npm-package-wrangler-1881

Or you can use npx with this latest build directly:

npx https://prerelease-registry.developers.workers.dev/runs/3083726244/npm-package-wrangler-1881 dev path/to/script.js

github-actions[bot] avatar Sep 18 '22 17:09 github-actions[bot]

Codecov Report

Merging #1881 (1c699d1) into main (d8fe95d) will increase coverage by 0.48%. The diff coverage is 7.69%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1881      +/-   ##
==========================================
+ Coverage   76.89%   77.38%   +0.48%     
==========================================
  Files         104      105       +1     
  Lines        7341     7485     +144     
  Branches     1928     1976      +48     
==========================================
+ Hits         5645     5792     +147     
+ Misses       1696     1693       -3     
Impacted Files Coverage Δ
packages/wrangler/src/proxy.ts 17.85% <7.69%> (-0.63%) :arrow_down:
packages/wrangler/src/pages/dev.tsx 21.71% <0.00%> (-1.24%) :arrow_down:
packages/wrangler/src/pages/publish.tsx 62.57% <0.00%> (-0.46%) :arrow_down:
packages/wrangler/src/inspect.ts 5.53% <0.00%> (-0.09%) :arrow_down:
packages/wrangler/src/pages/constants.ts 100.00% <0.00%> (ø)
...ngler/src/pages/functions/routes-transformation.ts 100.00% <0.00%> (ø)
.../wrangler/src/pages/functions/routes-validation.ts 92.42% <0.00%> (ø)
packages/wrangler/src/dev.tsx 85.37% <0.00%> (+0.47%) :arrow_up:
packages/wrangler/src/pages/functions.tsx 54.83% <0.00%> (+3.22%) :arrow_up:
packages/wrangler/src/dev/start-server.ts 76.00% <0.00%> (+3.58%) :arrow_up:
... and 3 more

codecov[bot] avatar Sep 18 '22 17:09 codecov[bot]

FYI, I've just put up a PR against Miniflare to fix a small bug related to the code you've copied: https://github.com/cloudflare/miniflare/pull/382

Not sure if it affects you here, but worth testing.

GregBrimble avatar Sep 19 '22 13:09 GregBrimble

Good catch, resolved

Skye-31 avatar Sep 19 '22 15:09 Skye-31

(Provided tests pass) I'm going to merge this in now

Doesn't look like we have proxy server tests? Maybe this is something we should address...

cameron-robey avatar Sep 26 '22 12:09 cameron-robey