terraform-provider-cloudflare

terraform-provider-cloudflare copied to clipboard

update os_version device posture terraform docs for new linux fields

changelog detected :white_check_mark:

you'll need to check out https://github.com/cloudflare/terraform-provider-cloudflare/blob/master/contributing/registry-documentation.md on how to have this documentation updated as docs is the automatically generated version of these files.

I see, my bad. Thanks!

these fields are now present in the Go library so you can add them to the schema, CRUD operations and the docs.

️✅ There are no secrets present in this pull request anymore.

If these secrets were true positive and are still valid, we highly recommend you to revoke them. Once a secret has been leaked into a git repository, you should consider it compromised, even if it was deleted immediately. Find here more information about risks.

---

<sup><sub>🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Our GitHub checks need improvements? Share your feedbacks!</sub></sup>

i've pushed a few fixes here but the test suite is still failing with a service error. do you mind looking into this and getting the tests in the right shape?

TF_ACC=1 go test $(go list ./...) -v -run "^TestAccCloudflareDevicePostureRule_" -count 1 -parallel 1 -timeout 120m -parallel 1
?       github.com/cloudflare/terraform-provider-cloudflare     [no test files]
=== RUN   TestAccCloudflareDevicePostureRule_SerialNumber
--- PASS: TestAccCloudflareDevicePostureRule_SerialNumber (20.79s)
=== RUN   TestAccCloudflareDevicePostureRule_OsVersion
--- PASS: TestAccCloudflareDevicePostureRule_OsVersion (17.22s)
=== RUN   TestAccCloudflareDevicePostureRule_OsDistroName
    resource_cloudflare_device_posture_rule_test.go:103: Step 1/1 error: Error running apply: exit status 1

        Error: error creating Device Posture Rule for account "f037e56e89293a057740de681ac9abbe": access.api.error.invalid_device_posture_integration_type (12094)

          with cloudflare_device_posture_rule.phnddkhwtf,
          on terraform_plugin_test.tf line 2, in resource "cloudflare_device_posture_rule" "phnddkhwtf":
           2: resource "cloudflare_device_posture_rule" "phnddkhwtf" {

--- FAIL: TestAccCloudflareDevicePostureRule_OsDistroName (3.37s)
=== RUN   TestAccCloudflareDevicePostureRule_OsDistroRevision
    resource_cloudflare_device_posture_rule_test.go:140: Step 1/1 error: Error running apply: exit status 1

        Error: error creating Device Posture Rule for account "f037e56e89293a057740de681ac9abbe": access.api.error.invalid_device_posture_integration_type (12094)

          with cloudflare_device_posture_rule.xihdkeyskf,
          on terraform_plugin_test.tf line 2, in resource "cloudflare_device_posture_rule" "xihdkeyskf":
           2: resource "cloudflare_device_posture_rule" "xihdkeyskf" {

--- FAIL: TestAccCloudflareDevicePostureRule_OsDistroRevision (3.36s)
=== RUN   TestAccCloudflareDevicePostureRule_DomainJoined
--- PASS: TestAccCloudflareDevicePostureRule_DomainJoined (24.96s)
=== RUN   TestAccCloudflareDevicePostureRule_Firewall
--- PASS: TestAccCloudflareDevicePostureRule_Firewall (15.92s)
=== RUN   TestAccCloudflareDevicePostureRule_DiskEncryption
--- PASS: TestAccCloudflareDevicePostureRule_DiskEncryption (23.11s)
FAIL
FAIL    github.com/cloudflare/terraform-provider-cloudflare/internal/provider   109.388s
?       github.com/cloudflare/terraform-provider-cloudflare/version     [no test files]
FAIL
make: *** [testacc] Error 1

depends on cloudflare/cloudflare-go#1087

with the upstream PR shimmed in, tests are passing

TF_ACC=1 go test $(go list ./...) -v -run "^TestAccCloudflareDevicePostureRule_" -count 1 -parallel 1 -timeout 120m -parallel 1
?       github.com/cloudflare/terraform-provider-cloudflare     [no test files]
=== RUN   TestAccCloudflareDevicePostureRule_SerialNumber
--- PASS: TestAccCloudflareDevicePostureRule_SerialNumber (16.55s)
=== RUN   TestAccCloudflareDevicePostureRule_OsVersion
--- PASS: TestAccCloudflareDevicePostureRule_OsVersion (15.39s)
=== RUN   TestAccCloudflareDevicePostureRule_LinuxOsDistro
--- PASS: TestAccCloudflareDevicePostureRule_LinuxOsDistro (12.75s)
=== RUN   TestAccCloudflareDevicePostureRule_DomainJoined
--- PASS: TestAccCloudflareDevicePostureRule_DomainJoined (15.87s)
=== RUN   TestAccCloudflareDevicePostureRule_Firewall
--- PASS: TestAccCloudflareDevicePostureRule_Firewall (17.78s)
=== RUN   TestAccCloudflareDevicePostureRule_DiskEncryption
--- PASS: TestAccCloudflareDevicePostureRule_DiskEncryption (17.27s)
PASS
ok      github.com/cloudflare/terraform-provider-cloudflare/internal/provider   96.001s
?       github.com/cloudflare/terraform-provider-cloudflare/version     [no test files]

This functionality has been released in v3.25.0 of the Terraform Cloudflare Provider.

Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!