cf-terraforming icon indicating copy to clipboard operation
cf-terraforming copied to clipboard

cloudflare_access_group resources are invalid

Open schack opened this issue 2 years ago • 1 comments

Confirmation

  • [X] My issue isn't already found on the issue tracker.
  • [X] I have replicated my issue using the latest version of the library and it is still present.

cf-terraforming version

v0.13.0

Expected outcome

resource "cloudflare_access_group" "terraform_managed_resource_e04041e3-1535-4dbf-8e82-2b8c526c671b" { name = "Partner: Vodafone" zone_id = "xxxxxxxxxxxxxxxxxxxxxx" include { email_domain = { domain = ["vodafone.com"] } } }

Actual outcome

resource "cloudflare_access_group" "terraform_managed_resource_e04041e3-1535-4dbf-8e82-2b8c526c671b" { name = "Partner: Vodafone" zone_id = "xxxxxxxxxxxxxxxxxxxxxx" include { email_domain = { domain = "vodafone.com". <--- missing [ ] } } }

Steps to reproduce

cf-terraforming generate -z xxxxxxxxxxxxxxxxxxxxxx --resource-type "cloudflare_access_group"

According to documentation, pretty much anything must be a list of strings.

https://registry.terraform.io/providers/cloudflare/cloudflare/latest/docs/resources/access_group#nestedblock--include

References

No response

schack avatar Aug 10 '23 07:08 schack

+1 this issue as it's still a relevant problem that prevents the cloudflare_access_group resource type for auto code generation from being valid (requires manual correction).

Schachte avatar Dec 15 '23 18:12 Schachte