lora

lora copied to clipboard

a bit of code cleanup & comments to make the code bit more accessible, no functional changes

Hi @vlordier. Thanks for the PR. I see quite a few issues with the code though.

I started a review, but there's a higher level question that probably should be answered first, which is: what should the formatting standard for the project be?

I use Black + Flake8 personally, and would advocate for that to be the standard (something like https://github.com/hafriedlander/stable-diffusion-grpcserver/blob/main/.vscode/settings.json) - @cloneofsimo do you have any preferences?

Oh, also, PRs should be raised against develop rather than master

Yes it seems like many differences come from formatting. I think I use black with default linebreaks but ill notify when Im home