cli icon indicating copy to clipboard operation
cli copied to clipboard

Adding emoji reaction support

Open TechnologyClassroom opened this issue 3 years ago • 5 comments

Describe the feature or problem you’d like to solve

It would be cool to have the ability to give emoji reactions to comments when working with issues or pull requests with gh.

Proposed solution

It could look something like this:

cli$ gh pr react 14
? Which comment would you like to react to? 3
>> 1 This is an issue.
>> 2 I agree.
>> 3 I was able to reproduce the issue and solve it with this change...
? Which emoji reaction would you like to use? 1
>> 1 +1
>> 2 -1
>> 3 smile
>> 4 tada
>> 5 thinking_face
>> 6 heart
>> 7 rocket
>> 8 eyes
✓ Reacted +1 to comment I was able to reproduce the issue...

Or if all of the information was known, it could simply be something like this:

gh pr react 14 3 1

Additional context

Adding support for emoji reactions could remove the need to open issues and pull requests in a browser.

TechnologyClassroom avatar Aug 30 '22 20:08 TechnologyClassroom

@TechnologyClassroom Thanks for writing in. I like the idea, and I like using emoji but I feel like the biggest hurdle to adding this feature is creating a UI that is effective and not confusing. This feature runs into the same UI concerns that the team has had about updating comments. We still have not come up with a great solution to how to pick which comment to update/add emoji to, we will consider the UX you proposed above. For now I think this feature is probably best tackled by an external extension.

samcoe avatar Aug 31 '22 06:08 samcoe

The proposed UI could potentially also work for updating comments, deleting comments, etc. Working with individual comments would be very helpful.

I got the idea from the interactive choice when selecting base repositories for pull requests.

TechnologyClassroom avatar Aug 31 '22 12:08 TechnologyClassroom

I'm curious how the UI would work for issues with a lot of comments, like >100. Would there be some sort of pagination so that a user can scroll through multiple comments at a time (maybe up/down for next previous, left/right for -/+10 comments?)? How to differentiate between a user wanting to view and react to new comments vs viewing for the first time and wanting to start from the beginning?

Or is the intended usage only for a small subsection of comments, like the last 30 (like what the default behavior of gh issue list is for issues)?

spenserblack avatar Sep 12 '22 16:09 spenserblack

Extension to simplify emoji reaction on issues

LangLangBart avatar Sep 18 '22 05:09 LangLangBart

@LangLangBart You should add MIT license to that repo so it can be merged when ready.

TechnologyClassroom avatar Sep 18 '22 19:09 TechnologyClassroom