Calvin

Results 37 comments of Calvin

It's not guaranteed this module will always be dependent on `axios`--in fact, a few versions ago, it wasn't! [It used to depend on `got`.](https://github.com/slackapi/node-slack-sdk/pull/620) My point is testing with the...

🤔 I don't think that just because something is in the original source code indicates it should be a regular dependency. For example, take documentation tools that read JSDoc comments....

> I can see your point of view but a language feature isn't the same as something external tooling parses (jsdoc). In the eyes of the ECMAScript standard and Node.js,...

### `MessageAttachment` Sample To foster discussion, here's a sample typing for `MessageAttachment`: `MessageAttachment` sample ```ts export type MessageAttachment = { color?: string; pretext?: string; actions?: MessageAttachmentAction[]; // actions are complicated,...

### Generics I actually originally wanted a way to express these constraints as generics originally (possibly different than what @aoberoi meant by "generics") but I couldn't remember a way to...

Just to echo what was already said (and somewhat agreed on), imagine seeing this in your editor: ![image](https://user-images.githubusercontent.com/9995434/56875554-00a68200-69ff-11e9-8fbf-f0e46eae951f.png) Seeing this for the first time (or even just looking past it...

🤔 The Node v4.2 build is [mysteriously failing while `npm` is installing](https://travis-ci.org/slackapi/hubot-slack/jobs/567155377). I'm going to add some debugging (`-dd` to `npm install`) to the CI config for this branch (🙇‍♀...

Eek! Sorry 🙇!! I accidentally deleted the old default branch without changing the target of this PR and it automatically closed this PR! And I couldn't change it unless I...

I've been seeing many reports of this, so I trust that this report is true, but I haven't had the time to repro it myself. After digging in, I suspect...

Thanks for the crash report! This looks like the same crash as #41839 to me, especially if it ends up that the crash address is null and the crashing function...