react-infinite-calendar

react-infinite-calendar copied to clipboard

Hi,

Is there a way to display states like birthday, federal holidays, events on each day?

I think the best way to go about this would be to provide a custom day renderer function and a custom selected state renderer. This would allow for maximal flexibility. Thoughts?

yes I was thinking something like that. Basically looking at date component at it is written now, it has 2 parts. Wrapper Component that handles click events and disabled state, and creates data needed for display component. And Display Component, which receives the needed data, and handles state('selected', 'normal'). So it would be nice if user can provide this custom display component.

What do you think?

I can implement it on weekend, if you want I need this exact functionality in my app so I can test it there.

I have a pretty good idea of how I would implement it, but I'm curious to see how you would implement it. How about you take a first stab at it and we'll take it from there :)

Yeah thats sounds like a good plan :)

@clauderic @marek-sed it would be pretty neat if there was a tool-tip shown when an event is hovered on or clicked on. What do you guys think?

@marek-sed @clauderic what is the status on this?

Haven't heard back from @marek-sed, I'll get around to tackling this next week or so. Tooltip would be nice for sure, but I'm probably going to build the logic for this to be as abstract as possible and then provide a couple of example recipes

Hi @clauderic @jamestwiggle , sry I went silent, was quite busy. I just issued the pull request for this.

EDIT: and broke a bunch of tests, fixing it now :) EDIT: fixed

when can you release the new npm package that merged this pull request ?

Regards. @clauderic

I'll take a look at it next week, I'm currently on vacation :)

@clauderic I understand this may be your side project, but do you know when you will be able to support this?

@clauderic any update on this?

@marek-sed @clauderic Also curious if this is on any one of your radar still?

This would be fairly simple to implement with the new architecture of react-infinite-calendar@^2.0.0.

This isn't something I have bandwidth to work on at the moment, but if this is something you're interested in, you can take a look at the implementation of the withMultipleDates HOC: https://github.com/clauderic/react-infinite-calendar/blob/master/src/Calendar/withMultipleDates.js.

I think the implementation for displaying events would be fairly similar.

I would be happy to take a stab at this, but Im new to recompose, so I could use a little help coming up to speed. Can someone please explain what this line does from the above mentioned file?

withProps(({displayDate, onSelect, setDisplayDate, scrollToDate, ...props}) => ({

I think I understand that it is doing something magical to inject props into the secret wrapper container around Calendar. Im not quite sure where those 5 arguments come from and where they are going. In particular, where is "scrollToDate" defined? Thanks!

@offsky He is using destructuring to select the props that are coming before it and modifying them in some way before passing them to the wrapped component. I hope that helps.

Is it possible to display events now? The pull request is there, but is it merged?

@marek-sed @clauderic @Makashov is this already possible? please tell me is ready! it has been two years waiting on this feature and we are in version 2.3.1