cluster-api-control-plane-provider-kamaji icon indicating copy to clipboard operation
cluster-api-control-plane-provider-kamaji copied to clipboard

Renaming the CRD's name to KamajiControlPlaneProvider

Open jds9090 opened this issue 1 year ago • 2 comments

The main role of Kamaji Control Plane is just for linking with CAPI. So, we need to check TCP(tenant Control Plane) if we want to check the status of control plane in detail.

That's why this repo's name is cluster-api-control-plane-provider-kamaji, not cluster-api-control-plane-kamaji.

I suggest renaming the CRD's name to KamajiControlPlaneProvider.

$: kubectl get kamajicontrolplaneprovider
NAME                       VERSION   INITIALIZED   READY   AGE
capi-quickstart   1.23.10   true          true    60d

Related to #66

jds9090 avatar Dec 12 '23 08:12 jds9090

I'm up for a discussion about this, although the renaming would be hard to tackle.

  1. You would need to create all the new resources with the new name.
  2. After that, all the TenantControlPlane instances must be patched with the right OwnerReference to the new resource
  3. Finally, the old resources can be deleted, as well as the old CRD

I'm keeping the issue open to collect feedback from other users.

prometherion avatar Dec 12 '23 08:12 prometherion

I'm up for a discussion about this, although the renaming would be hard to tackle.

  1. You would need to create all the new resources with the new name.
  2. After that, all the TenantControlPlane instances must be patched with the right OwnerReference to the new resource
  3. Finally, the old resources can be deleted, as well as the old CRD

I'm keeping the issue open to collect feedback from other users.

Thank you for your consideration :)

jds9090 avatar Dec 12 '23 08:12 jds9090