russ icon indicating copy to clipboard operation
russ copied to clipboard

Published 20 hours ago • verified publisher icon ckampfe

Fix doubled key input on Windows, Fixes ckampfe/russ#22

Open sobharrison opened this issue 2 years ago • 1 comments

On Windows all key events would be taken as input including keyup leading to double inputs.

Fixes ckampfe/russ#22 https://github.com/ckampfe/russ/issues/22

sobharrison avatar Oct 25 '23 08:10 sobharrison

Note, this change has only been tested on Windows. Needs to be tested on other OSes

sobharrison avatar Oct 25 '23 08:10 sobharrison

@sobharrison thank you very much for your contribution. I've tested this on MacOS and it appears to work the same with no regression. I will take your word for it that it works on Windows, as I do not use Russ on Windows myself.

Unfortunately I recently introduced a large refactoring to how Russ handles input, and so this PR conflicts with that. I was able to pull your changes in and commited them here https://github.com/ckampfe/russ/commit/4c3e25931f13276f0c591eac57f6ed0af95fe08f

Again, thank you for the contribution, and I hope this is a satisfactory outcome for your work.

ckampfe avatar Jun 01 '24 21:06 ckampfe