Cole Wagner
Cole Wagner
/ok-to-test
> We should still be clear about what our policy for the general case is though and if we act like we are a lib. cc @chaodaiG @cjwagner In my...
How would we would distinguish OWNERS_ALIASES from GitHub teams? Using GitHub teams instead of OWNERS_ALIASES would dramatically increase API token usage for all plugins that use OWNERS files unless the...
Yeah ghproxy will make this pretty much free in terms of rate limit, but it could be very expensive without. I think thats fine as long as we mention that...
> so this will need a rebase, but before we ask OP to do so, is this something we're willing to move forward with? cc @stevekuznetsov @alvaroaleman @chaodaiG @cjwagner The...
> We might want to decide whether or not new features are enabled by default - what's the current situation with flags? Perhaps the config could list disabled checks and...
Coming here from https://github.com/shurcooL/graphql/issues/29... I think the `do` function should be doing a best effort attempt to return the response body as part of the error message for any error...
Instead of having the leaf config struct type be `json.RawMessage` I was imagining we could use an interface: ```go type LeafConfig interface { MarshalJSON() ([]byte, error) UnmarshalJSON([]byte) error Apply(parent LeafConfig)...
> I'm pretty sure the ast package _et al_ are provided by the language specifically to allow people to do what I mentioned. I'm not familiar with that package and...
AST sounds cool and would likely provide the cleanest API, but I think the interface approach will be nearly as clean, will probably be simpler, and will allow for more...