cinny icon indicating copy to clipboard operation
cinny copied to clipboard

Update prod-deploy.yml

Open GoliathLabs opened this issue 3 years ago • 3 comments

Description

I've added the GH-Cache setting for the build-push action. This should speed up the build process.

Fixes #

Type of change

  • [X] Bug fix (non-breaking change which fixes an issue)
  • [ ] New feature (non-breaking change which adds functionality)
  • [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • [ ] This change requires a documentation update

Checklist:

  • [X] My code follows the style guidelines of this project
  • [X] I have performed a self-review of my own code
  • [X] I have commented my code, particularly in hard-to-understand areas
  • [X] I have made corresponding changes to the documentation
  • [X] My changes generate no new warnings

Preview: https://62f2df6c8a2c4f25bef1bdcc--pr-cinny.netlify.app ⚠️ Exercise caution. Use test accounts. ⚠️

GoliathLabs avatar Aug 09 '22 13:08 GoliathLabs

I have also introduced the arm v7 target for the image (for those using the image on an older SoC)

GoliathLabs avatar Aug 09 '22 13:08 GoliathLabs

I have tested both the PRs and the build time is the same https://github.com/kfiven/cinny/actions/runs/2831366316 Wondering if we are doing it correct.

kfiven avatar Aug 10 '22 14:08 kfiven

According to https://github.com/docker/build-push-action/blob/master/docs/advanced/cache.md#github-cache this should be correct. But it also depends on what parts can be cached by Github. It might make sense to cache already at the PR level, so that we can mostly reuse the build from the PR when merging into the dev branch

GoliathLabs avatar Aug 10 '22 17:08 GoliathLabs