IntelliJ-Inspection-Lens

IntelliJ-Inspection-Lens copied to clipboard

The idea is to start creating configuration for the plugin. Best way to start : Color customization.

I've worked on a poc already, it will need to rethink the color system by using TextAttributesKeys configurable with xml files.

For now, nothing is linked to the plugin, it's just some UI work. See : https://github.com/synopss/IntelliJ-Inspection-Lens/tree/feat/settings

Having the option to disable the background color would be a good start. The easiest solution is probably to inherit some already existing color settings but I think a standalone color setting for the plugin would be better in case you want to have different colors for actual warnings within the code.

Disable the background color would be possible with the solution above, you can just uncheck it, which will remove it. And since every gravity is handled separately, you will be able to combine some errors with background color and other without.

Also, I am not sure to understand your second point, can you elaborate more ?

I thought about it and with the background line colors I made the call to not add customization, primarily because every single thing that's in this plugin becomes my responsibility to not only test - which gets tricky with customization options - but also be expected to maintain basically forever... so for now, any customization is probably best left for a community fork.

Understandable, I'll stop there then. I'll keep the fork open so you change your mind, you'll have some kind of basis if you need one.

Forget what I said synopss. But I'd really like to use your fork with the customization option then. Would you publish a release on it so I don't have to build it myself? :)

I'm wondering what is the reason for wanting color customization in the first place, because specific problems such as:

• "I customized the colors in 'Color Scheme - Errors and Warnings' and now the default colors in the plugin don't match" or
• "The plugin doesn't work well with a high contrast theme"

can be solved without the users having to customize every color in the plugin.

I agree that it’s not particularly important. My perspective is simple: some people enjoy customizing things. Is it mandatory? Definitely not. Is it a nice-to-have? Probably.

As you pointed out, allowing customization might lead to users choosing odd color combinations, but that’s not really the plugin’s responsibility.

You can already customize colors of error stripe marks or underlines for both standard and user-defined inspections though, to me it would make more sense for the plugin to adapt to those colors instead.

I have started an experiment in that area, not sure if/when I'll have any results.