Dmitrii Kovanikov
Dmitrii Kovanikov
I think that supporting use-case with the existing `dotfiles` repo is worth pursuing. I can propose the following solution: 1. In `OnlyRepo` case ask interactively what users want to do:...
@SanchayanMaity Hmm, let me think carefully about invariants we want to preserve and how to handle them properly. I don't have an answer at the moment on the best approach...
Oh, I just realized that this requires to have `Set`...
Another case: * https://github.com/kowainik/summoner/pull/422 ``` 2020-02-23T17:28:54.140660+00:00 app[web.1]: [Info] [23-02-2020 17:25:51.085] [Hintman.Webhook.prReviewHook#84] [ThreadId 338] Review triggered for: kowainik/summoner/422 2020-02-23T17:28:54.140660+00:00 app[web.1]: [Error] [23-02-2020 17:25:51.530] [Hintman.Webhook.prReviewHook#94] [ThreadId 338] Failed to fetch PR deltas:...
After looking at logs on Heroku I would like to have the following configuration: 1. Disable timestamp printing by flag (heroku already add this info). 2. Filter by severity (to...
@vrom911 I agree that the whole diff from `master` should be reviewed again, even if some suggestions are going to be duplicated. Keeping track of previous suggestions is extremely difficult...
Another question: should `hintman` be triggered on `Reopened` PRs? Or should we make it configurable with `disabled` by default to not annoy people?
@vrom911 Makes sense. Let's trigger only on opened PRs and on the explicit request. Unfortunately, with GitHub UI it's very easy to accidentally close and reopen PR.
This would be awesome when this API appears!
@vrom911 I agree here with your reasoning 👍🏻 Even though, I'm not used to writing code like this, I feel that this consistency is very beneficial. Moreover, I imagine we...