Dmitrii Kovanikov

Results 365 comments of Dmitrii Kovanikov

I'm leaning towards the `--update-config` option for two reasons: 1. According to CLI Guidelines, tools shouldn't mutate user-facing files unless specified explicitly. 2. One possible use case for the `tool...

#97 looks pretty separate to me 👍🏻 This issue can be implemented separately. I imagine a pretty small diff. It's just adding proper imports, dev dependencies and quickly verifying that...

Looks like we can use `clippy` configuration options `disallow_methods` to forbid the usage of specific functions: * https://rust-lang.github.io/rust-clippy/master/#disallowed_method My plan would be the following: * Try this config option to...

@MitchellBerend I found this `clippy` issue: * https://github.com/rust-lang/rust-clippy/issues/8065 It suggests that there's a hidden option `--tests` that you can use to run `clippy` in tests (and it doesn't run in...

Oh, didn't notice 😮 In that case, I'm not sure how to fix it 🤔

> Or `tool install clementtsang/bottom --exe_name btm` This is exactly how I imagine the final API 🙂 Thanks for writing it explicitly! If it's just `tool_name` then `tool-sync` checks among...

> Would the implementation of this serialization be implemented in the binary itself or only in the test? It'll be used only for tests. So I expect that it'll be...

@MitchellBerend Indeed, it's always good to revisit our assumptions 😌 In this issue, I want to only test the `default-config.toml` and make sure that the code under comments is valid....

> this is unblocked now Thanks! I'll update the description ✅ > sc uses tar.xz, which needs support in archive module too. Indeed, this needs to be supported separately. Feel...

The `checksum` field is the way to go 👍🏻 I've checked some common tools. Not many of them provide checksums in their GitHub releases but a few tools to actually...