chrono icon indicating copy to clipboard operation
chrono copied to clipboard

Published 20 hours ago • verified publisher icon chronotope

Convert `NaiveDate::{from_yo|from_isoywd}` to return `Result`

Open pitdicker opened this issue 1 year ago • 2 comments

cc @Zomtir. I would like to depend on these methods when working on the Parsed type, and you don't seem to have started on them yet.

pitdicker avatar Feb 25 '24 20:02 pitdicker

Codecov Report

Attention: Patch coverage is 98.93617% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 94.33%. Comparing base (f0e6695) to head (03727e8).

Files Patch % Lines
src/naive/date/mod.rs 97.67% 1 Missing :warning:
Additional details and impacted files 
@@           Coverage Diff           @@
##            0.5.x    #1460   +/-   ##
=======================================
  Coverage   94.33%   94.33%           
=======================================
  Files          37       37           
  Lines       17004    17011    +7     
=======================================
+ Hits        16040    16047    +7     
  Misses        964      964

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Feb 25 '24 20:02 codecov[bot]

Simplified from_isoywd a bit and made that into a commit that can apply to the main branch.

pitdicker avatar Feb 26 '24 10:02 pitdicker

I'll keep this PR open a little longer until we have a new merge of main with the 0.5.x branch.

pitdicker avatar Feb 27 '24 15:02 pitdicker