hstspreload.org icon indicating copy to clipboard operation
hstspreload.org copied to clipboard

The validation button is still too small

Open ZerooCool opened this issue 5 years ago • 8 comments

Change the CSS so that the validation button (at the bottom of the page) can display all the text content.

ZerooCool avatar Nov 18 '19 20:11 ZerooCool

Could I ask you to provide a screenshot so we know what needs fixing?

lgarron avatar Nov 19 '19 02:11 lgarron

1920 x 1080 for my resolution.

I can't make a screenshot because validation is pending.

This last button is not wide enough and the font must be reduced, otherwise the text is not displayed correctly, and some of the text is truncated.

I have found the issue : https://github.com/chromium/hstspreload.org/pull/170 2 button need to be update, not only the first.

ZerooCool avatar Nov 20 '19 17:11 ZerooCool

@ZerooCool you should submit a PR :)

XhmikosR avatar Jan 27 '20 16:01 XhmikosR

For the button at the bottom, this is better :

Replace max-width: 22em; by max-width: 25em;

Please, add this in a PR.

ZerooCool avatar Jan 27 '20 19:01 ZerooCool

I'm not sure the solution is to increase the button width. Instead the button text should wrap. Or even better, we should have the text separated from the button action.

XhmikosR avatar Jan 28 '20 08:01 XhmikosR

It's right. In my case, I was able to obtain a correct rendering with my proposal. Separating the text (URL it seems to me) from the button is actually a very good thing.

ZerooCool avatar Jan 28 '20 14:01 ZerooCool

Increasing the width is not right and it's moot since domains can have a big length. The proper solution would be to untie the button for the text.

XhmikosR avatar Jan 28 '20 14:01 XhmikosR

Yes quite.

ZerooCool avatar Jan 28 '20 14:01 ZerooCool