chroma icon indicating copy to clipboard operation
chroma copied to clipboard

Published 20 hours ago • verified publisher icon chroma-core

UUIDs and Strings

Open atroyn opened this issue 2 years ago • 3 comments

In several places, we convert UUID objects back and forth from and to strings. This isn't great, and it's hard to keep track of what they should be, when.

We should add types to make sure they are what we expect, and then refactor to try to do this conversion as little as possible, or preferably, not at all.

An example: https://github.com/chroma-core/chroma/blob/ddaabebd7570f4006a6990023a51fcb0c7ba7301/chromadb/api/local.py#L115

It's ambiguous here what type collection_uuid should be.

atroyn avatar Feb 14 '23 22:02 atroyn

@levand I believe we are addressing this as a part of the refactor? Should we keep it open or close it?

jeffchuber avatar Mar 29 '23 00:03 jeffchuber

This will be handled in the refactor, not urgent until then.

levand avatar Mar 29 '23 20:03 levand

Great! Will leave this open then.

jeffchuber avatar Mar 29 '23 21:03 jeffchuber

This will be handled in the refactor, not urgent until then.

Refactor has landed! Closing this issue.

jeffchuber avatar Aug 29 '23 13:08 jeffchuber