greek-name-klitiki icon indicating copy to clipboard operation
greek-name-klitiki copied to clipboard

Στυλιανός is transformed to Στυλιανό instead of Στυλιανέ

Open chrispanag opened this issue 7 years ago • 4 comments

The lib transforms all the names that end with -ός by removing the 'ς' (Νικολός -> Νικολό). 'Στυλιανός' is an exception to this rule and can't be modeled as a specific rule.

We'll need to create a way to support some exceptions to each rule, so that exceptions are scalable.

chrispanag avatar Sep 13 '18 15:09 chrispanag

I'd say that "Νικολός" is probably the exception here. See other -ός male names (for example, exhaustive list of names starting with A, taken from onomatologio.gr ): Αγαπητός Αδριανός Αιμιλιανός Ακριβός Ασκληπιός Αυγερινός

all these should be -έ

pappasadrian avatar Jan 04 '21 15:01 pappasadrian

Good point, an exception list should be added nevertheless...

If there is enough interest for this package, I can resume development, maybe add some tests etc.

chrispanag avatar Jan 04 '21 15:01 chrispanag

hello, I just saw this repo being mentioned here https://www.facebook.com/pappasadrian/posts/738203123464595:26 and I thought I'd take a look. I'm actually adding some extra tests right now, that if I am guessing correctly, will fail with the current rules

pappasadrian avatar Jan 04 '21 15:01 pappasadrian

open a PR and let's investigate what we can do to solve those problems... :)

chrispanag avatar Jan 04 '21 15:01 chrispanag