Chris Krycho

Results 673 comments of Chris Krycho

I suggest explicitly mentioning the prior art from the Rust community, in part because many of the discussions they had about the Rust Edition process will prove illuminating to people...

Octane shipped; we have *done* an edition! Presumably this should move into FCP now? 😂

The decorators syntax is still not stable, and `setComponentTemplate` actually came after our adoption of decorators. Decorators were officially adopted in #408 (merged January 2019), while `setComponentTemplate` was #481 (merged...

The Framework team will need to get on the same page to make sure, but I think we need this as part of the path *to* that most likely. In...

@tylerbecks I think that's a different issue than this one!

The lightest-weight move is to have a trivial base class and have the constructor receive `owner`. That's what we do with `@glimmer/component`: it receives `owner` and `args`. Doing the same...

Yep, I was just enumerating the actual trade offs around the options you enumerated! As regards a base class, I don’t think that level of duplicated functionality is something to...

Another plus side for being able to splat arguments and similar is that it makes one variant of higher-order components quite nice: you can just wrap an existing component, make...

Thanks for reopening over here. I believe `willDestroy` (and more importantly [the `destroyModifier` API](https://emberjs.github.io/rfcs/0373-Element-Modifier-Managers.html#destroymodifier) on which it is built) *does* first right before `this.element` is removed from the DOM; does...

One thing this calls out (which I've been talking about with folks as we look at how to design components around these kinds of APIs going forward) is that add-ons...