chriseth

Results 231 comments of chriseth

We could add another clause that is only executed on call-related errors (either no code at destination or decoding error): ``` try ... { } catch ... { } callError...

I'm sorry, but we don't want to release binaries that did not go through our testing pipeline. It's by the way totally fine and danger-free to work with a compiler...

I wonder if we should target the breaking branch for this.

The thing is that if we require checksums, we require the "caller" to include the full keccak algorithm as a dependency. Does it create an error or a warning? In...

If the recommended checksum is not too hard to parse, it may be a good solution for a caller that does not have a keccak library to just iterate.

Do I understand you correctly that you find it confusing that the catch block is only executed when the call reverted? Would you want the catch block to be executed...

If you send ether to the called function in the try/catch, how do you distinguish the ether being gone or not in the catch clause? The try/catch statement was not...

Can you please share a bit more about your use-case? It is difficult to discuss breaking invariants at such an abstraction level without any examples.

Ok, from your example, I see that the problem is rather the excodesize check and not the decoding failure (as you already said above). I think changing the behaviour of...

@hrkrshnn noted that if we go to the catch block on excodesizecheck failure, we have to re-add the extcodesizecheck that was recently removed due to a decoding error resulting in...