Stripping comments in production builds
It looks like we preserve comments when running the browserify transform on the tagged template literals source.
I'd like to remove all comments from production builds in order to:
- Not accidentally leak information/context that I did not want to leak in prod.
- Reduce build size.
First things that come to mind:
Potential Solution 1
browserify -t [nanohtml --strip-comments ] strips comments
FWIW I wouldn't mind if stripping comments was the default or if nanohtml just always stripped comments since I never use comments in the browser. I only use HTML comments while reading code.
.. But I recognize that other people might want them in by default / that could maybe lead to less confusion maybe.. so whatever works!
Oh and I'm also more than happy to PR this once we know what we want to do!
The only reason that the transform has them is because the browser version has them too. We could drop them in both.
Sorry just to clarify - I should PR a removal of the comment handling and we're good to go https://github.com/choojs/nanohtml/blob/master/lib/browserify-transform.js#L112-L114 ?