redux-boot icon indicating copy to clipboard operation
redux-boot copied to clipboard

Published 20 hours ago • verified publisher icon choko-org

Added initial state functionality to modules.

Open lucasconstantino opened this issue 9 years ago • 4 comments

lucasconstantino avatar Jul 17 '16 17:07 lucasconstantino

@lucasconstantino I think this PR is doing some refactors which could be in different PR in order to review it better.

The code of which enables the initial state for modules is really great, and I think we can do it in a way it isn't close the door to Immutable libraries (for example ImmutableJS).

Given that I think we can do PR which enables the developers to extend the processModules and implement more behaviors like this one.

@recidive and @lucasconstantino how we could do the initial state handled in way we don't loose compatibility with immutable libraries?

sebas5384 avatar Jul 24 '16 23:07 sebas5384

@lucasconstantino I did PR over this issue, to avoid the mutation of state object passed as reference. Let me know what you think, @recidive gives me his "ok", so if you agree on this please make the merge of https://github.com/lucasconstantino/redux-boot/compare/initial-state...sebas5384:patch-1 and I'll merge this PR right away!

sebas5384 avatar Sep 03 '16 18:09 sebas5384

Done ;)

lucasconstantino avatar Sep 03 '16 19:09 lucasconstantino

@lucasconstantino awesome!!

Oh! I think we forgot the documentation, so I'll document it and send you a PR later 👍

sebas5384 avatar Sep 03 '16 20:09 sebas5384