openmmtools icon indicating copy to clipboard operation
openmmtools copied to clipboard

Fixing FIREMinimizerIntegrator

Open hannahbrucemacdonald opened this issue 6 years ago • 1 comments

Previously NaN check prevented the integrator from taking any uphill steps, when the correct protocol should allow for n_min consecutive uphill steps.

Relaxing test criteria (tolerance and max_iterations) as test was erroneously passing before as ^ was causing delta_t to decrease rapidly

hannahbrucemacdonald avatar Apr 29 '19 21:04 hannahbrucemacdonald

I just realized that jax-md provides a FIRE minimizer as well, so maybe we can also check against their implementation.

jaimergp avatar May 22 '19 09:05 jaimergp