Chinmay Garde

Results 244 comments of Chinmay Garde

@dnfield Closing this as a duplicate of https://github.com/flutter/flutter/issues/110723. I've cross referenced these and gone though the comments to ensure I didn't miss any context. That bug has some details related...

Hmm, today there are only two ways of enabling Impeller on iOS. Either via the run configuration that [adds a "command line" flag](https://github.com/flutter/engine/blob/e7696f4f03cc46f026cb1bc56bdd8c9536b06de9/shell/platform/darwin/ios/framework/Source/FlutterDartProject.mm#L55), or, updating the [`Info.plist` in the Flutter...

Agreed on the size overhead. It'd be minimal. In the interim, as folks are doing runtime switching, this sounds like a good idea to me too.

I believe the `CreateUnifiormMemberKey` member needs to be patched in `buffer_bindings_gles.cc`. Seems simple enough. We can tackle this when we focus on non-Darwin platforms.

@mraleph Are the situation in which entrypoint annotations are necessary documented? Also, is it possible to emulate the failures due to missing entrypoint annotations in debug modes. As it stands,...

These are unhandled or partially handled mutator stack items. The issue on iOS is the same as https://github.com/flutter/flutter/issues/35062 and there is a potential fix linked. cc @jmagman And the Android...

Good catch. For some reason, in go/impeller-whats-left, there is a note saying this wasn't exposed by Flutter.

From the Impeller Weekly sync: This would also allow us to use the embedder test harnesses on Mac as Impeller smoke tests. Elevating priority and assigning.

Making good progress on this. Should land this for Metal this week.