intelmq icon indicating copy to clipboard operation
intelmq copied to clipboard

DomainTools Expert Bot (initial version)

Open aaronkaplan opened this issue 8 years ago • 9 comments

demo of how to use the domaintools expert to fetch scoring for a domain

aaronkaplan avatar Jun 11 '17 19:06 aaronkaplan

Codecov Report

Merging #1004 into develop will increase coverage by 2.26%. The diff coverage is 85.93%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #1004      +/-   ##
===========================================
+ Coverage     75.8%   78.06%   +2.26%     
===========================================
  Files          216      223       +7     
  Lines         9108     9136      +28     
  Branches      1215        0    -1215     
===========================================
+ Hits          6904     7132     +228     
- Misses        1920     2004      +84     
+ Partials       284        0     -284
Impacted Files Coverage Δ
...elmq/tests/bots/experts/domaintools/test_expert.py 100% <100%> (ø)
intelmq/bots/experts/domaintools/expert.py 79.54% <79.54%> (ø)
...ntelmq/bots/collectors/alienvault_otx/collector.py 34.78% <0%> (-17.85%) :arrow_down:
...q/bots/collectors/blueliv/collector_crimeserver.py 32.14% <0%> (-13.7%) :arrow_down:
...telmq/bots/experts/ripencc_abuse_contact/expert.py 88.88% <0%> (-9.48%) :arrow_down:
intelmq/bots/collectors/misp/collector.py 34.48% <0%> (-6.9%) :arrow_down:
...telmq/tests/bots/outputs/postgresql/test_output.py 93.54% <0%> (-6.46%) :arrow_down:
...elmq/bots/collectors/mail/collector_mail_attach.py 25.71% <0%> (-5.72%) :arrow_down:
intelmq/bots/outputs/stomp/output.py 30.55% <0%> (-5.56%) :arrow_down:
intelmq/bots/experts/maxmind_geoip/expert.py 18.42% <0%> (-5.27%) :arrow_down:
... and 108 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 4efedf4...3a400cf. Read the comment docs.

codecov-io avatar Jun 11 '17 19:06 codecov-io

pls review

aaronkaplan avatar Jun 12 '17 03:06 aaronkaplan

pls review

Done

ghost avatar Jul 27 '17 15:07 ghost

Do you want to work on these issues or should I revise this bot?

ghost avatar Aug 14 '17 09:08 ghost

Do you want to work on these issues or should I revise this bot?

I did some work on this one. Waiting confirmation from @aaronkaplan https://github.com/aaronkaplan/intelmq/pull/1

SYNchroACK avatar Dec 14 '17 10:12 SYNchroACK

I don't have an API key, so can't test this at the moment

ghost avatar Jun 19 '18 11:06 ghost

Closing because of inactivity. Please reopen if needed.

ghost avatar Feb 05 '19 17:02 ghost

definitely needed. Reopening. What we can do is to re-write this PR completely but , yes , domaintools is needed.

aaronkaplan avatar Nov 04 '19 11:11 aaronkaplan

Is this PR still being worked on?

ghost avatar Apr 08 '21 07:04 ghost