cert-manager icon indicating copy to clipboard operation
cert-manager copied to clipboard

Use CUE to generate values.yaml and values.schema.json

Open inteon opened this issue 3 years ago • 3 comments

Pull Request Motivation

Currently, the Helm values.yaml file is not validated, often causing configuration errors. This PR uses CUE to define what configurations are supported in the values.yaml file.

Kind

/kind feature

Release Note

Added Helm values validation based on CUE definition

inteon avatar Aug 04 '22 21:08 inteon

Skipping CI for Draft Pull Request. If you want CI signal for your change, please convert it to an actual PR. You can still manually trigger a test run with /test all

jetstack-bot avatar Aug 04 '22 21:08 jetstack-bot

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: inteon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

jetstack-bot avatar Aug 04 '22 21:08 jetstack-bot

@inteon: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

jetstack-bot avatar Aug 09 '22 19:08 jetstack-bot

@inteon: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-cert-manager-master-make-test cf124a6b376e02be7258182961daacd5ca76a1e2 link true /test pull-cert-manager-master-make-test
pull-cert-manager-master-e2e-v1-24-upgrade cf124a6b376e02be7258182961daacd5ca76a1e2 link true /test pull-cert-manager-master-e2e-v1-24-upgrade
pull-cert-manager-master-e2e-v1-24 cf124a6b376e02be7258182961daacd5ca76a1e2 link true /test pull-cert-manager-master-e2e-v1-24
pull-cert-manager-master-chart cf124a6b376e02be7258182961daacd5ca76a1e2 link true /test pull-cert-manager-master-chart

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

jetstack-bot avatar Aug 19 '22 08:08 jetstack-bot

BLOCKED: The generated json-schema code contains a lot of allOf directives, which do not play well with additionalProperties: false.

inteon avatar Aug 24 '22 21:08 inteon

@inteon: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-cert-manager-master-make-test cf124a6b376e02be7258182961daacd5ca76a1e2 link true /test pull-cert-manager-master-make-test
pull-cert-manager-master-e2e-v1-24 cf124a6b376e02be7258182961daacd5ca76a1e2 link true /test pull-cert-manager-master-e2e-v1-24
pull-cert-manager-master-chart cf124a6b376e02be7258182961daacd5ca76a1e2 link true /test pull-cert-manager-master-chart
pull-cert-manager-master-e2e-v1-25 cf124a6b376e02be7258182961daacd5ca76a1e2 link true /test pull-cert-manager-master-e2e-v1-25
pull-cert-manager-master-e2e-v1-24-upgrade cf124a6b376e02be7258182961daacd5ca76a1e2 link true /test pull-cert-manager-master-e2e-v1-24-upgrade
pull-cert-manager-master-e2e-v1-25-upgrade cf124a6b376e02be7258182961daacd5ca76a1e2 link true /test pull-cert-manager-master-e2e-v1-25-upgrade

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

jetstack-bot avatar Oct 07 '22 13:10 jetstack-bot

@inteon: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-cert-manager-master-make-test cf124a6b376e02be7258182961daacd5ca76a1e2 link true /test pull-cert-manager-master-make-test
pull-cert-manager-master-e2e-v1-24 cf124a6b376e02be7258182961daacd5ca76a1e2 link true /test pull-cert-manager-master-e2e-v1-24
pull-cert-manager-master-chart cf124a6b376e02be7258182961daacd5ca76a1e2 link true /test pull-cert-manager-master-chart
pull-cert-manager-master-e2e-v1-25 cf124a6b376e02be7258182961daacd5ca76a1e2 link true /test pull-cert-manager-master-e2e-v1-25
pull-cert-manager-master-e2e-v1-24-upgrade cf124a6b376e02be7258182961daacd5ca76a1e2 link true /test pull-cert-manager-master-e2e-v1-24-upgrade
pull-cert-manager-master-e2e-v1-25-upgrade cf124a6b376e02be7258182961daacd5ca76a1e2 link true /test pull-cert-manager-master-e2e-v1-25-upgrade
pull-cert-manager-master-e2e-v1-26-upgrade cf124a6b376e02be7258182961daacd5ca76a1e2 link true /test pull-cert-manager-master-e2e-v1-26-upgrade

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

jetstack-bot avatar Dec 19 '22 10:12 jetstack-bot

Issues go stale after 90d of inactivity. Mark the issue as fresh with /remove-lifecycle stale. Stale issues rot after an additional 30d of inactivity and eventually close. If this issue is safe to close now please do so with /close. Send feedback to jetstack. /lifecycle stale

jetstack-bot avatar Mar 19 '23 11:03 jetstack-bot