cert-manager icon indicating copy to clipboard operation
cert-manager copied to clipboard

Make the Helm chart container names unique to help troubleshoot

Open rgl opened this issue 3 years ago • 0 comments

Is your feature request related to a problem? Please describe.

Currently, all the Helm chart container names are derived from the Helm release as name: {{ .Chart.Name }}, but this makes troubleshoot harder.

For example, after installing cert-manager with helm upgrade --install ..., these warnings all referred to a cert-manager container, although they are not really the same, they are in fact for cert-manager, cainjector, webhook, and startupapicheck, making troubleshoot harder:

W0731 20:03:17.231208   17824 warnings.go:70] would violate PodSecurity "restricted:latest": unrestricted capabilities (container "cert-manager" must set securityContext.capabilities.drop=["ALL"]), seccompProfile (pod or container "cert-manager" must set securityContext.seccompProfile.type to "RuntimeDefault" or "Localhost")
W0731 20:03:17.271225   17824 warnings.go:70] would violate PodSecurity "restricted:latest": unrestricted capabilities (container "cert-manager" must set securityContext.capabilities.drop=["ALL"]), seccompProfile (pod or container "cert-manager" must set securityContext.seccompProfile.type to "RuntimeDefault" or "Localhost")
W0731 20:03:17.281414   17824 warnings.go:70] would violate PodSecurity "restricted:latest": unrestricted capabilities (container "cert-manager" must set securityContext.capabilities.drop=["ALL"]), seccompProfile (pod or container "cert-manager" must set securityContext.seccompProfile.type to "RuntimeDefault" or "Localhost")
W0731 20:03:34.196210   17824 warnings.go:70] would violate PodSecurity "restricted:latest": unrestricted capabilities (container "cert-manager" must set securityContext.capabilities.drop=["ALL"]), seccompProfile (pod or container "cert-manager" must set securityContext.seccompProfile.type to "RuntimeDefault" or "Localhost")

Describe the solution you'd like

A different name for each container to clearly identify them in logs.

/kind feature

rgl avatar Aug 02 '22 05:08 rgl

@rgl I agree that this could be a useful change; feel free to create a PR to implement this.

inteon avatar Aug 28 '22 09:08 inteon

@inteon, please take a look at #5410.

rgl avatar Aug 28 '22 11:08 rgl