kombu icon indicating copy to clipboard operation
kombu copied to clipboard

CurlClient isn't used anymore and probably could be deleted

Open dobosevych opened this issue 3 years ago • 7 comments

CurlClient isn't used anymore and it is broken for a lot of time, so probably can be removedhttp/curl.py. There are several reasons for that

  1. It depends on pycurl that isn't in any dependencies, so on next code we will receive an error
from kombu.asynchronous.http.curl import CurlClient
c = CurlClient()
  1. I don't see any usage client CurlClient or Client in celery repo

In any case code could be at least cleaned

dobosevych avatar Apr 19 '22 06:04 dobosevych

Hey @dobosevych :wave:, Thank you for opening an issue. We will get back to you as soon as we can. Also, check out our Open Collective and consider backing us - every little helps!

We also offer priority support for our sponsors. If you require immediate assistance please consider sponsoring us.

it was scheduled to removed

auvipy avatar Apr 19 '22 09:04 auvipy

pycurl might have usage in kombu most probably

auvipy avatar Apr 19 '22 09:04 auvipy

but it isn't in any dependencies already should I help with code cleaning?

dobosevych avatar Apr 19 '22 09:04 dobosevych

boto sqs?

auvipy avatar Apr 19 '22 09:04 auvipy

pip install kombu
>>> from kombu.asynchronous.http.curl import CurlClient
>>> c = CurlClient()

will lead to an error. This I suppose should be fixed or cleaned. What is your suggestion?

dobosevych avatar Apr 19 '22 09:04 dobosevych

https://github.com/celery/kombu/issues/737 check this please

auvipy avatar Apr 23 '22 08:04 auvipy

Why does kombu needs pycurl but doesn't specify this in requirements? Can someone please help with this. Thank you.

shadowrider17 avatar Jan 26 '23 18:01 shadowrider17