django-celery-beat icon indicating copy to clipboard operation
django-celery-beat copied to clipboard

Package not handling Daylight Savings Time

Open codeadict opened this issue 7 years ago • 12 comments

Seems like this package is not handling daylight savings time correctly when a timezone is set as a field, for example, both Django and Celery are running in DST but I create a crontab to run at every day at 9:00 AM in US/Eastern, when the DST changes tasks are not properly executed. I don't see any test case for this in the package but I see them for Celery. Happy to contribute a fix if this is a confirmed issue, I have test cases for it but may have wrongly configured it.

codeadict avatar Oct 31 '18 21:10 codeadict

@auvipy ping

codeadict avatar Nov 06 '18 19:11 codeadict

Any advice on this @thedrow @tinylambda

codeadict avatar Nov 20 '18 15:11 codeadict

whats the update with latest release or master?

auvipy avatar Dec 12 '18 08:12 auvipy

It was with the latest release, wrote some tests with Master as well and not working

codeadict avatar Dec 12 '18 15:12 codeadict

Any updates on this? I'm being asked if our task runtimes will start earlier due to the DST change and saw this issue while searching for answers.

Planswalker avatar Feb 15 '19 16:02 Planswalker

is it still not fixed in master?

auvipy avatar Apr 22 '19 14:04 auvipy

I'm not working with this package or Python anymore, can do some testing against master again over the weekend

codeadict avatar Apr 22 '19 16:04 codeadict

The next DST change is coming soon ...

wryfi avatar Sep 17 '19 06:09 wryfi

@auvipy do you have reason to believe this has been fixed?

wryfi avatar Sep 20 '19 00:09 wryfi

@codeadict have you identified where in the code this problem might lie?

wryfi avatar Sep 21 '19 15:09 wryfi

Hi @wryfi , i actually stopped working on the company we used this package, cannot remember what my results after debugging it were.

codeadict avatar Sep 22 '19 03:09 codeadict