Cee Chen

Results 258 comments of Cee Chen

https://github.com/elastic/eui/pull/7930 has a spike of this work if y'all would like to review the changes here: - [Form controls](https://eui.elastic.co/pr_7930/#/forms/form-controls) - [Button groups in forms](https://eui.elastic.co/pr_7930/#/navigation/button#buttonGroup-compressed) - [Filter groups](https://eui.elastic.co/pr_7930/#/forms/filter-group) - [Inline edit](https://eui.elastic.co/pr_7930/#/forms/inline-edit)

@1Copenut Question, does EuiSelectable also now require a border at all times, with increased contrast? https://eui.elastic.co/pr_7930/#/forms/selectable

Hey @davismcphee! Just wanted to check in on this PR - it looks great to me honestly, should I go ahead and mark its as ready for review + add...

Adding a throttler/debouncer to the width changes would be the next step to improving performance - would that be something y'all would like to request as a feature/prop as well?

It's the most obvious approach that I can think of, but I have no idea if that's the difference between browsers, and it isn't guaranteed to fix the issue per...

> It looks like `useResizeObserver` relies on `getBoundingClientRect` because `contentRect` only provides the content sizing for elements instead of box sizing: > [...] > But I assume this code is...

@davismcphee Yes, 100%, I definitely want that change! 😄

@davismcphee Alrighty, I've updated the PR with latest main and pushed up the minor changes I had - did you want to re-test the performance impacts to make sure everything's...

@davismcphee I know I'm asking for larger/higher level changes, so LMK at any point if you'd prefer us to simply take over the PR instead of going through tedious feedback...

`toolTipContent` and `toolTipProps` and their typings look perfect - thanks Davis!! ❤️ No rush on this at all, feel free to take all the time you need on this! And...