casbin-mesh icon indicating copy to clipboard operation
casbin-mesh copied to clipboard

Published 20 hours ago • verified publisher icon casbin

feat(raft): introduce read index

Open noneback opened this issue 3 years ago • 12 comments

Signed-off-by: noneback [email protected]

noneback avatar May 10 '22 16:05 noneback

@WenyXu @nodece please review

casbin-bot avatar May 10 '22 16:05 casbin-bot

CLA assistant check
All committers have signed the CLA.

CLAassistant avatar May 10 '22 16:05 CLAassistant

Draft. I only change the enforce-related code to see if it fits.

noneback avatar May 10 '22 17:05 noneback

@noneback don't make WIP PR. First work in your local branch and then create the final PR

hsluoyz avatar May 12 '22 11:05 hsluoyz

I need to spend some time for review this PR.

nodece avatar May 16 '22 15:05 nodece

nodece

Thx for your patience！ You can review it at your convenience.

noneback avatar May 16 '22 15:05 noneback

Well done, But I consider we still need to add tests for this PR. Before adding tests, we need to decouple the main function's parsing flags(the relevant issue #58 ), which makes integration testing more manageable. I will handle this issue later this week. If you are willing, you can make a decoupling of the parsing flags PR, then add tests for this PR.

WenyXu avatar May 17 '22 12:05 WenyXu

Thanks for your contribution, most of the work is great, I left my comment.

nodece avatar May 17 '22 14:05 nodece

Thx. I will fix them all in my spare time.

noneback avatar May 17 '22 14:05 noneback

@noneback can you continue pushing this PR? Also resolve the conflict:

image

hsluoyz avatar Jun 26 '22 10:06 hsluoyz

Sure. I will fix conflict and try to add some test

noneback avatar Jun 27 '22 07:06 noneback

/cc @nodece @WenyXu

hsluoyz avatar Jun 28 '22 07:06 hsluoyz