Carson Katri

Results 219 comments of Carson Katri

I've got the code up at [`carson-katri/router`](https://github.com/carson-katri/router). There are definitely improvements to be made, so feel free to open issues/PRs there now. Also, it only supports SwiftUI ATM.

We already do some flattening in [ModifiedContent](https://github.com/swiftwasm/Tokamak/blob/b93be40a19d3f6aa831a9e95d2d70b7a2bb5a40b/Sources/TokamakStaticHTML/Modifiers/_ViewModifier_Content.swift#L34), but it could definitely be improved. One thing to be careful of is: ```swift .padding() .background(Color.red) ``` should become: ```css padding: 8px; background-color:...

Most lists are meant to fill their container (We should probably replace that with a flexible frame, I don't think they were working when that was implemented). Sidebar is different...

> pre-render your Tokamak app into a static HTML, serve that by default, and then hydrate that after the WebAssembly binary is loaded SwiftUI will be getting a `isPlaceholder` modifier...

There's also the [``](https://developer.mozilla.org/en-US/docs/Web/HTML/Element/dialog) element, but it has poor browser support atm.

Here's what the interface looks like for `ButtonStyle`: ```swift @available(iOS 13.0, OSX 10.15, tvOS 13.0, watchOS 6.0, *) public protocol ButtonStyle { associatedtype Body : SwiftUI.View func makeBody(configuration: Self.Configuration) ->...

I think a separate issue would be good, since this is particularly about SwiftUI compatibility, whereas that is DOM renderer specific. Also, I don't think implementing ButtonStyle, TextFieldStyle, etc. would...

I like the idea of using xcassets. Although I’ve never used them outside Xcode, and wonder if that would be a subpar experience for people developing on non-Apple platforms? Probably...

This is probably because we started using grid for stacks instead of flex box because of the `gap` property. However, I think flexbox supports the gap property in most browsers,...

Here's is the browser support for flexbox gap for reference: https://caniuse.com/flexbox-gap