architecture-viewer icon indicating copy to clipboard operation
architecture-viewer copied to clipboard

Support .puml file extension

Open hkdobrev opened this issue 5 years ago • 1 comments

Some systems and tools would record sequence diagrams in files with the .puml file extension.

Architecture viewer however does not accept them unless they are with the .adoc extension. The exactly same file works with .adoc, but does not with .puml.

Could you support the files regardless of the file extension?

hkdobrev avatar Sep 09 '20 11:09 hkdobrev

Instead of just adding .puml, I think we could make this even more permissive and allow any file extension. I don't think there's a lot of value in restricting the viewer to just .adoc files at the moment.

I'd happily accept a pull request for this change if anybody wants to submit it (automated tests will need to be updated along with the change). If I get a lot of community demand for the feature then I can probably implement it.

I'm not sure if we currently show a good error message for unparseable files, so we might also want to improve the error reporting for invalid files (since they'll become a bit more likely if we allow users to import files with any extension).

daj avatar Sep 10 '20 02:09 daj